Simplifier Pass #4700
Closed
Simplifier Pass #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
commented
Aug 28, 2024
.github/workflows/CI.yml
Outdated
| @@ -4,11 +4,13 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - simplifier_pass | |||
There was a problem hiding this comment.
We can probably remove this part, because this will get tested thanks to this PR being open against main ("pull request against main"), thanks to the "main" being mentioned below. That way we avoid double testing.
ASR->LLVM: handle association to PointerNullConstant by creating just a store
chore: merge specific commits from `array_op_refac` branch
Merge main into simplifier pass
chore: merge `main` into `simplifier_pass`
simplifier pass: uncomment passing test case
uncomment passing tests
…bol-array-size fix: do ASR verification conditionally for `ExternalSymbol` in `ArraySize`
tests: enable testing `parameter_13`
simplifier pass: use `m_value` for replacing Var, when available
simplifier pass: convert initialization to assignment in the same scope as initialization
tests: enable testing `intrinsics_311.f90` with `--realloc-lhs` flag
Merge main into simplifier pass
sync back 'subroutine_from_function.cpp' with main
undo tab changes and update reference tests
chore: merge `main` into `simplifier_pass`
chore: resolve merge conflicts
…function-registry-simplifier chore: bring back changes from `main` using `use_experimental_simplifier` guard
chore: shorten diff between `main` and `simplifier_pass`
|
I don't know what happened here: I used the online "resolve conflicts" feature, and to create a new branch. And it instead retargeted this PR to be from the new branch.... Anyway, here is the PR into simplifier: #5181 |
Closed
|
Closing in favor of #5182. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-running branch and a PR with a simplifier pass. To collaborate on this, simply send a PR against this
simplifier_passbranch and if merged, it will automatically appear in this PR. We can use this PR to easily see what the changes are againstmainand our goal is to get these changes to the point that we can merge it. The CI should always be green in this PR.TODO to merge simplifier_pass into main:
sync w main
ASR.asdlwith main #5161asdl_cpp.pywith main #5160asr_verifywith main #5136gen_pass.pywith main #5146intrinsic_func_registry_util_gen.pywith main #5159array_oppass with main #5125implied_do_loops,init_expr,pass_utils.h/.cppwith simplifier #5115implied_do_loops,init_expr,pass_utils.h/.cppwith simplifier #5115inline_function_callsandinstantitate_templatepass #5116inline_function_callsandinstantitate_templatepass #5116intrinsic_function.cpp,intrinsic_array_function_registry.hwith simplifier #5126intrinsic_function.cpp,intrinsic_array_function_registry.hwith simplifier #5126implied_do_loops,init_expr,pass_utils.h/.cppwith simplifier #5115implied_do_loops,init_expr,pass_utils.h/.cppwith simplifier #5115array_oppass with main #5125subroutine_from_functionpass with main #5129wherepass with main #5130TODO after sync with main
--experimental-simplifierflag for third party tests and other places as well