Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff in place of black, flake8, reorder-python-imports, pyupgrade #1209

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Use ruff in place of black, flake8, reorder-python-imports, pyupgrade #1209

wants to merge 28 commits into from

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Nov 17, 2024 •
edited
Loading

This replaces our use of the black, flake8, reorder-python-imports and pyupgrade pre-commit hooks with ruff.

Attempts are made here to minimize the number of code changes necessary to match ruff's rules while at the same time not adding blanket-ignores for rules.

Issue(s) Resolved

Fixes #1206

Related Issues / Links

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)

dairiki added 18 commits November 17, 2024 16:31
@dairiki
fixup: configure ruff's isort
bd9a61d
@dairiki
style: ruff isort fixes
f2999bd
@dairiki
tests: enable ruff's flake8-bugbear checks
8bcc788
@dairiki
fix: fix issues surface by ruff's flake8-bugbear checks
5472f54
@dairiki
style: enable ruff's pyupgrade rules (except f-string rules)
1b5df7d
@dairiki
fix: address issues surfaced by ruff's pyupgrade rules
7cea1b3
@dairiki
style: enable ruff's UP032 rule (.format → f-string)
aba41b7
@dairiki
fix: address issues surfaced by UP032
a2daebc
@dairiki
style: enable ruff's UP031 (% → f-string) rule
1071fd2
@dairiki
fix: address issues surfaced by ruff's UP031
0a0bac0
@dairiki
style: enable ruff's flake8-comprehensions rules
3744220
@dairiki
style: address flake8-comprehensions rule suggestions
ab45001
@dairiki
refactor(i18n): use importlib.resources to read translation files
77874c7
@dairiki
style: enable ruff's flake8-implicit-str-concat rules
5b9a370
@dairiki
style: address flake8-implicit-str-concat rule suggestions
1d7828c
@dairiki
style: enable ruff's FLY rules
99721eb
@dairiki
style: address FLY rule suggestion
39adda6
@dairiki
style: enable ruff's FURB rules
4cda9a4
@dairiki dairiki force-pushed the feat.ruff branch 2 times, most recently from 351c0d2 to 0484141 Compare November 18, 2024 01:53
@webknjaz webknjaz mentioned this pull request Nov 18, 2024
Merged
@dairiki dairiki added testing ci related to Lektor's continous integration labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

Assignees
No one assigned
Labels
ci related to Lektor's continous integration testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

black==2024 is incompatible with reorder-python-imports
2 participants
@dairiki @webknjaz