Improve some type hinting

le717 · Jun 8, 2024 · b59174e · b59174e
1 parent 62a698e
commit b59174e
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -23,11 +23,17 @@ httpx = "^0.27.0"
 mypy = "^1.10.0"
 pytest = "^8.2.2"
 ruff = "^0.4.8"
+types-flask-cors = "^4.0.0.20240523"
 
 [build-system]
 requires = ["poetry-core"]
 build-backend = "poetry.core.masonry.api"
 
+[tool.mypy]
+[[tool.mypy.overrides]]
+module = ["flask_smorest", "sys_vars", "sqlalchemy"]
+ignore_missing_imports = true
+
 [tool.ruff]
 target-version = "py311"
 line-length = 100

diff --git a/src/views/linkrot.py b/src/views/linkrot.py
@@ -12,7 +12,7 @@
 class LinkRotCheck(MethodView):
     @linkrot.arguments(models.AuthKey, location="query", as_kwargs=True)
     @linkrot.response(200, models.RotResult(many=True))
-    def post(self, **kwargs: Any) -> list[models.RotResult]:
+    def post(self, **kwargs: Any) -> list[db.RotResult]:
         """Check all links in the ring for link rot."""
         del kwargs["auth_key"]
         return db.check_all()
@@ -24,7 +24,7 @@ class LinkRotSingleCheck(MethodView):
     @linkrot.arguments(models.WebLinkId, location="path", as_kwargs=True)
     @linkrot.response(200, models.RotResult)
     @linkrot.alt_response(404, schema=models.HttpError)
-    def post(self, **kwargs: Any) -> models.RotResult:
+    def post(self, **kwargs: Any) -> db.RotResult | None:
         """Check a single link in the ring for link rot."""
         del kwargs["auth_key"]
         if (result := db.check_one(str(kwargs["id"]))) is None:

diff --git a/src/views/root.py b/src/views/root.py
@@ -1,4 +1,4 @@
-from typing import Any
+from typing import Any, Sequence
 from uuid import UUID
 
 from flask import abort, request
@@ -13,7 +13,7 @@
 class WebRing(MethodView):
     @root.arguments(models.WebLinkGet, location="query", as_kwargs=True)
     @root.response(200, models.WebLink(many=True))
-    def get(self, **kwargs: Any) -> list[models.WebLink]:
+    def get(self, **kwargs: Any) -> Sequence[models.WebLink]:
         """Fetch webring items.
 
         Provide the appropriate query string arguments to