final ruff fixes

le717 · Jun 8, 2024 · 15648d1 · 15648d1
1 parent dbdce77
commit 15648d1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 15 deletions.
diff --git a/db/env.py b/db/env.py
@@ -20,11 +20,8 @@
 config.set_main_option("sqlalchemy.url", db_uri)
 target_metadata = db.metadata
 
-# Configure anything else you deem important, example:
-# my_important_option = config.get_main_option("my_important_option")
 
-
-def run_migrations_offline():
+def run_migrations_offline() -> None:
     """
     Run migrations in 'offline' mode.
 
@@ -46,7 +43,7 @@ def run_migrations_offline():
         context.run_migrations()
 
 
-def run_migrations_online():
+def run_migrations_online() -> None:
     """
     Run migrations in 'online' mode.
 
@@ -57,7 +54,7 @@ def run_migrations_online():
     # If you use Alembic revision's --autogenerate flag this function will
     # prevent Alembic from creating an empty migration file if nothing changed.
     # Source: https://alembic.sqlalchemy.org/en/latest/cookbook.html
-    def process_revision_directives(context, revision, directives):
+    def process_revision_directives(context, revision, directives) -> None:  # noqa: ARG001
         if config.cmd_opts.autogenerate:
             script = directives[0]
             if script.upgrade_ops.is_empty():

diff --git a/db/seeds.py b/db/seeds.py
@@ -1,11 +1,9 @@
 # This file should contain records you want created when you run flask db seed.
 #
 # Example:
-# from yourapp.models import User
+# `from yourapp.models import User`
 
 
-# initial_user = {
-#     'username': 'superadmin'
-# }
+# `initial_user = {'username': 'superadmin'}
 # if User.find_by_username(initial_user['username']) is None:
-#     User(**initial_user).save()
+#     User(**initial_user).save()`
diff --git a/src/core/database/linkrot.py b/src/core/database/linkrot.py
@@ -32,7 +32,8 @@ def __ping_url(url: str) -> bool:
             httpx.codes.NO_CONTENT,
             httpx.codes.NOT_MODIFIED,
         )
-    except Exception:
+    except httpx.HTTPError as exc:
+        logger.exception("An error occurred when checking a URL for rotting.", exc_info=exc)
         return False
 
 

diff --git a/src/core/logger.py b/src/core/logger.py
@@ -1,5 +1,5 @@
 import logging
-from datetime import datetime
+from datetime import UTC, datetime
 from logging.handlers import RotatingFileHandler
 from pathlib import Path
 
@@ -15,7 +15,7 @@
 
 
 def _linkrot_formatter(record: logging.LogRecord) -> str:
-    msg_date = datetime.fromtimestamp(record.created).strftime("%B %d, %Y @ %I:%M:%S %p")
+    msg_date = datetime.fromtimestamp(record.created, tz=UTC).strftime("%B %d, %Y @ %I:%M:%S %p")
     return f""":warning: Webring Alert :warning:
 Alert level: **{record.levelname.capitalize()}**
 Date: {msg_date}

diff --git a/src/views/embed.py b/src/views/embed.py
@@ -31,6 +31,6 @@ def embed(**kwargs) -> Response:
 
     # Render the JavaScript module, taking care to indicate it's a JS file
     # so browsers correctly load it
-    resp = make_response(render_template("webring-embed.js", **{"all_links": all_links}))
+    resp = make_response(render_template("webring-embed.js", all_links=all_links))
     resp.mimetype = "text/javascript"
     return resp