Skip to content

Commit

Permalink
Merge pull request kubernetes#30839 from lavalamp/fix
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

queueActionLocked requires write lock

Fix kubernetes/minikube#368
Fix part of kubernetes#30759

Hopefully. On stack dumps I couldn't see who was fighting with this.
  • Loading branch information
Kubernetes Submit Queue authored Aug 18, 2016
2 parents e2f39fc + 3e69c5a commit 86340fc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/client/cache/delta_fifo.go
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,8 @@ func (f *DeltaFIFO) Replace(list []interface{}, resourceVersion string) error {

// Resync will send a sync event for each item
func (f *DeltaFIFO) Resync() error {
f.lock.RLock()
defer f.lock.RUnlock()
f.lock.Lock()
defer f.lock.Unlock()
for _, k := range f.knownObjects.ListKeys() {
obj, exists, err := f.knownObjects.GetByKey(k)
if err != nil {
Expand Down

0 comments on commit 86340fc

Please sign in to comment.