Skip to content

Commit

Permalink
A few more fixups
Browse files Browse the repository at this point in the history
  • Loading branch information
Isaac Hollander McCreery committed Nov 2, 2015
1 parent 235aaf7 commit 612158b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion release/build-official-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ ln -s ${KUBE_BUILD_DIR}/_output/release-tars/kubernetes.tar.gz ${KUBE_BUILD_DIR}
MD5=$(md5 "${KUBE_BUILD_DIR}/kubernetes.tar.gz")
SHA1=$(sha1 "${KUBE_BUILD_DIR}/kubernetes.tar.gz")

echo <<- EOM
cat <<- EOM
Success! You must now do the following: (you may want to cut
and paste these instructions elsewhere, step 1 can be spammy)
Expand Down
20 changes: 10 additions & 10 deletions release/cut-official-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ function alpha-release() {
- Finish the ${alpha_version} release build:
- From this directory (clone of upstream/master),
./release/build-official-release.sh ${alpha_version}
- Figure out what the PR numbers for this release and last release are, and
get an api-token from GitHub (https://github.com/settings/tokens). From a
clone of kubernetes/contrib at upstream/master,
go run release-notes/release-notes.go --last-release-pr=<number> --current-release-pr=<number> --api-token=<token>
Feel free to prune, but typically for patch releases we tend to include
everything in the release notes.
- Prep release notes:
- Figure out what the PR numbers for this release and last release are, and
get an api-token from GitHub (https://github.com/settings/tokens). From a
clone of kubernetes/contrib at upstream/master,
go run release-notes/release-notes.go --last-release-pr=<number> --current-release-pr=<number> --api-token=<token>
Feel free to prune.
EOM
}

Expand Down Expand Up @@ -226,12 +226,12 @@ function official-release() {
git-push "${official_version}"

cat >> "${INSTRUCTIONS}" <<- EOM
- Finish the ${version} release build:
- Finish the ${official_version} release build:
- From this directory (clone of upstream/master),
./release/build-official-release.sh ${version}
./release/build-official-release.sh ${official_version}
- Prep release notes:
- From this directory (clone of upstream/master), run
./hack/cherry_pick_list.sh ${version}
./hack/cherry_pick_list.sh ${official_version}
to get the release notes for the patch release you just created. Feel
free to prune anything internal, but typically for patch releases we tend
to include everything in the release notes.
Expand All @@ -245,7 +245,7 @@ function verify-at-git-commit() {
local -r git_commit="${1}"
echo "Verifying we are at ${git_commit}."
if [[ $(current-git-commit) != ${git_commit} ]]; then
echo <<- EOM
cat <<- EOM
!!! We are not at commit ${git_commit}! (If you're cutting an official release,
that probably means your release branch isn't frozen, so the commit you want to
release isn't at HEAD of the release branch.)"
Expand Down

0 comments on commit 612158b

Please sign in to comment.