Skip to content

Commit

Permalink
Remove Makefile undefined variables logic
Browse files Browse the repository at this point in the history
It didn't do what I thought it did and was just noise.  Specifically, it only
kicks in for recursive `make` invocations.
  • Loading branch information
thockin committed Jul 20, 2016
1 parent 8fb8f3d commit 5930c57
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ SHELL := /bin/bash
MAKEFLAGS += --no-builtin-rules
.SUFFIXES:

# We want make to yell at us if we use undefined variables.
MAKEFLAGS += --warn-undefined-variables

# Constants used throughout.
OUT_DIR ?= _output
BIN_DIR := $(OUT_DIR)/bin
Expand All @@ -47,20 +44,9 @@ PRJ_SRC_PATH := k8s.io/kubernetes
# Metadata for driving the build lives here.
META_DIR := .make

#
# Define variables that we use as inputs so we can warn about undefined variables.
#

WHAT ?=
TESTS ?=

GOFLAGS ?=
KUBE_GOFLAGS = $(GOFLAGS)
export KUBE_GOFLAGS GOFLAGS
export KUBE_GOFLAGS := $(GOFLAGS)

GOLDFLAGS ?=
KUBE_GOLDFLAGS = $(GOLDFLAGS)
export KUBE_GOLDFLAGS GOLDFLAGS
export KUBE_GOLDFLAGS := $(GOLDFLAGS)

# Build code.
#
Expand Down

0 comments on commit 5930c57

Please sign in to comment.