Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bad regex for loopback replacement for Issue #1503 #1504

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fixes bad regex for loopback replacement for Issue #1503 #1504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/Valet/Site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public function replaceOldLoopbackWithNew(string $siteConf, string $old, string

$lookups = [];
$lookups[] = '~#?listen .*:80; # valet loopback~';
$lookups[] = '~#?listen .*:443 ssl http2; # valet loopback~';
$lookups[] = '~#?listen .*:443 ssl; # valet loopback~';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This should suffice, since the old configs from when nginx used to support the http2 directive, won't work on current nginx versions anyway.

$lookups[] = '~#?listen .*:60; # valet loopback~';

foreach ($lookups as $lookup) {
Expand Down