[6.x] Allow cache helper to have an optional expiration parameter (sy…

…ntactic sugar for forever) (#31554) * Allow cache forever usage with helper * No longer needed
laravel · Feb 24, 2020 · 6ad1b81 · 6ad1b81
1 parent 61b5aa1
commit 6ad1b81
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/Illuminate/Foundation/helpers.php b/src/Illuminate/Foundation/helpers.php
@@ -250,13 +250,7 @@ function cache()
             );
         }
 
-        if (! isset($arguments[1])) {
-            throw new Exception(
-                'You must specify an expiration time when setting a value in the cache.'
-            );
-        }
-
-        return app('cache')->put(key($arguments[0]), reset($arguments[0]), $arguments[1]);
+        return app('cache')->put(key($arguments[0]), reset($arguments[0]), $arguments[1] ?? null);
     }
 }
 

diff --git a/tests/Foundation/FoundationHelpersTest.php b/tests/Foundation/FoundationHelpersTest.php
@@ -43,14 +43,6 @@ public function testCache()
         $this->assertSame('default', cache('baz', 'default'));
     }
 
-    public function testCacheThrowsAnExceptionIfAnExpirationIsNotProvided()
-    {
-        $this->expectException(Exception::class);
-        $this->expectExceptionMessage('You must specify an expiration time when setting a value in the cache.');
-
-        cache(['foo' => 'bar']);
-    }
-
     public function testUnversionedElixir()
     {
         $file = 'unversioned.css';