Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make type hint passed by mypy check for all the codebase in api/ #10928

Closed
5 tasks done
yihong0618 opened this issue Nov 21, 2024 · 2 comments · Fixed by #10921
Closed
5 tasks done

make type hint passed by mypy check for all the codebase in api/ #10928

yihong0618 opened this issue Nov 21, 2024 · 2 comments · Fixed by #10921
Assignees
@yihong0618
Labels
💪 enhancement New feature or request stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@yihong0618
Copy link
Contributor

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

for protect the bug

2. Additional context or comments

No response

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
@yihong0618
Copy link
Contributor Author

working on it #10921

@laipz8200 laipz8200 added the 💪 enhancement New feature or request label Nov 21, 2024
@yihong0618 yihong0618 mentioned this issue Nov 21, 2024
Merged
9 tasks
@dosubot DosuBot
Copy link

dosubot bot commented Dec 22, 2024

Hi, @yihong0618. I'm Dosu, and I'm helping the Dify team manage their backlog. I'm marking this issue as stale.

Issue Summary

  • The issue involves updating type hints in the api/ directory to comply with mypy checks.
  • You have expressed interest in contributing to this improvement.
  • A pull request (feat: mypy for all type check #10921) has been opened by you to address this issue.

Next Steps

  • Please let us know if this issue is still relevant to the latest version of the Dify repository by commenting on this issue.
  • If there is no further activity, the issue will be automatically closed in 15 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihong0618 yihong0618

Labels
💪 enhancement New feature or request stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: mypy for all type check yihong0618/dify
2 participants
@yihong0618 @laipz8200