Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support async version func run_as_str in zapier #3392

Closed
wants to merge 12 commits into from
Closed

support async version func run_as_str in zapier #3392

wants to merge 12 commits into from

Conversation

cangcang-zcr
Copy link

Can support asynchronous versions of run_as_str and related functions.

vowelparrot
vowelparrot reviewed Apr 23, 2023
View reviewed changes
Copy link
Contributor

@vowelparrot vowelparrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It'll look good once the async and synchronous function signatures are more aligned and the print statement is removed.

@dev2049 dev2049 requested a review from vowelparrot May 19, 2023 01:28
@mplachter mplachter mentioned this pull request Jun 27, 2023
Merged
@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 14, 2023
@baskaryan
Copy link
Collaborator

seems like this feature landed in #6791, closing but let me know if i'm missing anything!

@baskaryan baskaryan closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vowelparrot vowelparrot

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cangcang-zcr @baskaryan @vowelparrot @dev2049