Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add batch request support for text-embedding-v3 model #26375

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat: add batch request support for text-embedding-v3 model #26375

merged 4 commits into from
Oct 31, 2024

Conversation

yxleung
Copy link
Contributor

@yxleung yxleung commented Sep 12, 2024

PR title: “langchain: add batch request support for text-embedding-v3 model”

PR message:

•	Description: This PR introduces batch request support for the text-embedding-v3 model within LangChain. The new functionality allows users to process multiple text inputs in a single request, improving efficiency and performance for high-volume applications.
•	Issue: This PR addresses #<issue_number> (if applicable).
•	Dependencies: No new external dependencies are required for this change.
•	Twitter handle: If announced on Twitter, please mention me at @yourhandle.

Add tests and docs:

1.	Added unit tests to cover the batch request functionality, ensuring it operates without requiring network access.
2.	Included an example notebook demonstrating the batch request feature, located in docs/docs/integrations.

Lint and test: All required formatting and linting checks have been performed using make format and make lint. The changes have been verified with make test to ensure compatibility.

Additional notes:

•	The changes are fully backwards compatible.
•	No modifications were made to pyproject.toml, ensuring no new dependencies were added.
•	The update only affects the langchain package and does not involve other packages.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 6:54pm

@dosubot dosubot bot added langchain Related to the langchain package Ɑ: embeddings Related to text embedding models module labels Sep 12, 2024
@ccurme ccurme removed the langchain Related to the langchain package label Sep 20, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 31, 2024
@ccurme ccurme enabled auto-merge (squash) October 31, 2024 18:54
@ccurme ccurme merged commit 8ef0df3 into langchain-ai:master Oct 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxleung @ccurme