-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Ogre 1.12 #1526
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d" and "Ogre::WindowEventListener : expected class-name before '{' token"
Moved detection of the visp-images outside the vp_add_test method, to make the detection possible even when tests are disabled
…cause it seemed to cause a problem when running successive configure steps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 53.83% 54.01% +0.17%
==========================================
Files 442 441 -1
Lines 53871 53859 -12
==========================================
+ Hits 29004 29093 +89
+ Misses 24867 24766 -101 ☔ View full report in Codecov by Sentry. |
@rolalaro When I run the example on my Ubuntu 24.04 with Ogre 1.12 installed from existing package, I have an exception
|
…oying uninitialized vpAROgre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated vpAROgre and visp_ar CMakeLists to make ViSP compatible with Ogre 1.12