Fix stepic credentials saving: save only non-empty, non-default values

lada-gagina · Jul 29, 2016 · ac4ef4e · ac4ef4e
1 parent 459b771
commit ac4ef4e
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/...on/educational-core/student/src/com/jetbrains/edu/learning/stepic/StepicStudyOptions.java b/...on/educational-core/student/src/com/jetbrains/edu/learning/stepic/StepicStudyOptions.java
@@ -107,7 +107,8 @@ public void setLogin(@Nullable final String login) {
 
   @NotNull
   private String getPassword() {
-    return String.valueOf(myPasswordField.getPassword());
+    final String passwordText = String.valueOf(myPasswordField.getPassword());
+    return passwordText.equals(DEFAULT_PASSWORD_TEXT) ? "" : passwordText;
   }
 
   private void setPassword(@NotNull final String password) {
@@ -142,11 +143,12 @@ public void apply() {
       if (project != null) {
         StudyTaskManager taskManager = StudyTaskManager.getInstance(project);
         taskManager.setEnableTestingFromSamples(myEnableTestingFromSamples.isSelected());
-        final StepicUser user = taskManager.getUser();
-        user.setEmail(getLogin());
-        user.setPassword(getPassword());
-        if (!StringUtil.isEmptyOrSpaces(getLogin()) && !StringUtil.isEmptyOrSpaces(getPassword())) {
-          EduStepicConnector.login(getLogin(), getPassword());
+        final String login = getLogin();
+        final String password = getPassword();
+        if (!StringUtil.isEmptyOrSpaces(login) && !StringUtil.isEmptyOrSpaces(password)) {
+          final StepicUser user = taskManager.getUser();
+          user.setEmail(login);
+          user.setPassword(password);
         }
       }
       else {