Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BA-585): Empty tag image scan error in docker registry #3533

Merged
merged 10 commits into from
Jan 24, 2025
Merged

fix(BA-585): Empty tag image scan error in docker registry #3533

merged 10 commits into from
Jan 24, 2025

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Jan 23, 2025 •
edited
Loading

Resolves #3513 (BA-585).

This PR fixes an issue where an error occurs when rescanning images with empty tags (dangling images) in Docker registries.
After this PR, dangling images will be skipped, and only other valid images will be rescanned.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Jan 23, 2025
@jopemachine jopemachine added the type:bug Reports about that are not working label Jan 23, 2025
@jopemachine jopemachine added this to the 23.09 milestone Jan 23, 2025
@jopemachine jopemachine changed the title fix: Empty tag image scan error in docker registry fix(BA-585): Empty tag image scan error in docker registry Jan 23, 2025
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Jan 23, 2025
@jopemachine jopemachine force-pushed the fix/scan-empty-tag-img-error-in-docker-registry branch from 6a44a5d to 6d7574e Compare January 23, 2025 11:15
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Jan 24, 2025
@jopemachine jopemachine marked this pull request as ready for review January 24, 2025 05:03
HyeockJinKim
HyeockJinKim approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit e3149c4 Jan 24, 2025
20 checks passed
@HyeockJinKim HyeockJinKim deleted the fix/scan-empty-tag-img-error-in-docker-registry branch January 24, 2025 06:01
lablup-octodog pushed a commit that referenced this pull request Jan 24, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533)
4a5b273 
Backported-from: main (25.1)
Backported-to: 24.09
Backport-of: 3533
@lablup-octodog lablup-octodog mentioned this pull request Jan 24, 2025
Merged
@github-actions GitHub Actions
Copy link

Backport to 23.09 is failed. Please backport manually.

@github-actions GitHub Actions
Copy link

Backport to 24.03 is failed. Please backport manually.

jopemachine added a commit that referenced this pull request Jan 24, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533)
440c054 
Backported-from: main
Backported-to: 24.03
Backported-of: 3533
jopemachine added a commit that referenced this pull request Jan 24, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533)
1a7fbc0 
Backported-from: main
Backported-to: 23.09
Backported-of: 3533
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
@lablup-octodog @jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533) (#…
e62e170 
…3541)

Co-authored-by: Gyubong Lee <jopemachine@naver.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533) (#…
85df0f9 
…3542)
jopemachine added a commit that referenced this pull request Jan 24, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533)
73479c0 
Backported-from: main
Backported-to: 23.09
Backported-of: 3533
seedspirit pushed a commit that referenced this pull request Feb 4, 2025
@jopemachine @seedspirit
fix(BA-585): Empty tag image scan error in docker registry (#3533)
2a60210
seedspirit pushed a commit that referenced this pull request Feb 5, 2025
@jopemachine @seedspirit
fix(BA-585): Empty tag image scan error in docker registry (#3533)
7facc99
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@jopemachine @Yaminyam
fix(BA-585): Empty tag image scan error in docker registry (#3533)
2da8d0c
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@jopemachine @Yaminyam
fix(BA-585): Empty tag image scan error in docker registry (#3533)
5d403fd
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
@jopemachine
fix(BA-585): Empty tag image scan error in docker registry (#3533) (#…
d02fdc6 
…3543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@jopemachine jopemachine

Labels
comp:manager Related to Manager component size:L 100~500 LoC type:bug Reports about that are not working
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Missing exception handling for images with empty tags in Docker registries
2 participants
@jopemachine @HyeockJinKim