fix: Correct worker metrics to provide metrics across all dimensions #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have `datetime` and `status` as dimensions for the CloudFlare Worker invocation metrics GraphQL query. This causes CloudFlare workers to output a number of datapoints for each unique tuple of dimensions, across several `datetime`s. For worker requests and errors this is fine as we `.Add(...)` to those counters, but for quantiles this causes us to only export the last datapoints quantiles, which may be an outlier. --- Removing the `datetime` for the query provides pre-aggregated datapoints for us to process. Further to this, `datetime` is not currently being captured in the response data structure.
This change adds `status` to the CloudFlare worker metrics being exported. This fixes an issue where, similar to `datetime` previously, we are getting multiple metric series from the combinations of unique dimensions. This resulted in only the last datapoint series being exported from the `cloudflare-exporter` for the CloudFlare workers. Additionally this provides more information as the `status` can be used to differentiate the internal errors seen in CloudFlare workers.
jackatbancast
changed the title
|
cc @haad if you have a chance to look at this it'd be appreciated as the worker metrics are currently a little incomplete/misleading. |
|
cc @martinhaus if you also have some time to look at this it'd be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have
datetimeandstatusas dimensions for the CloudFlare Worker invocation metrics GraphQL query.This causes CloudFlare workers to output a number of datapoints for each unique tuple of dimensions, i.e. across several
datetimes andstatuses.For worker requests and errors this is fine as we
.Add(...)to those counters, but for quantiles we use.Set(...)which causes us to only export the last datapoint quantiles, which may not representative of the entire dataset.Removing the
datetimefor the query provides pre-aggregated datapoints for us to process.Further to this,
datetimeis not currently being captured in the response data structure.statusis a useful dimension to disambiguate internal errors and the impact on performance across them. This change addsstatusto all of the worker metrics exported to reflect that, and to ensure we're not only using a single datapoint.