Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3151: disable null on internalID columns #3165

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Fix issue 3151: disable null on internalID columns #3165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8866ab9
disable null for internal id columns
ray6080 Mar 28, 2024
05288a3
fix test
ray6080 Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.15)

project(Kuzu VERSION 0.3.2.4 LANGUAGES CXX C)
project(Kuzu VERSION 0.3.2.5 LANGUAGES CXX C)

find_package(Threads REQUIRED)

Expand Down
2 changes: 1 addition & 1 deletion src/storage/store/column.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ InternalIDColumn::InternalIDColumn(std::string name, const MetadataDAHInfo& meta
BMFileHandle* dataFH, BMFileHandle* metadataFH, BufferManager* bufferManager, WAL* wal,
transaction::Transaction* transaction, RWPropertyStats stats, bool enableCompression)
: Column{name, *LogicalType::INTERNAL_ID(), metaDAHeaderInfo, dataFH, metadataFH, bufferManager,
wal, transaction, stats, enableCompression},
wal, transaction, stats, enableCompression, false /*requireNullColumn*/},
commonTableID{INVALID_TABLE_ID} {}

void InternalIDColumn::populateCommonTableID(ValueVector* resultVector) const {
Expand Down
6 changes: 3 additions & 3 deletions src/storage/store/rel_table_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ RelTableData::RelTableData(BMFileHandle* dataFH, BMFileHandle* metadataFH,
&DUMMY_WRITE_TRANSACTION, tableID, NBR_ID_COLUMN_ID, direction);
auto nbrIDColName = StorageUtils::getColumnName("NBR_ID", StorageUtils::ColumnType::DEFAULT,
RelDataDirectionUtils::relDirectionToString(direction));
auto nbrIDColumn = ColumnFactory::createColumn(nbrIDColName, *LogicalType::INTERNAL_ID(),
*nbrIDMetadataDAHInfo, dataFH, metadataFH, bufferManager, wal, &DUMMY_WRITE_TRANSACTION,
RWPropertyStats::empty(), enableCompression);
auto nbrIDColumn = std::make_unique<InternalIDColumn>(nbrIDColName, *nbrIDMetadataDAHInfo,
dataFH, metadataFH, bufferManager, wal, &DUMMY_WRITE_TRANSACTION, RWPropertyStats::empty(),
enableCompression);
columns.push_back(std::move(nbrIDColumn));
// Property columns.
for (auto i = 0u; i < properties.size(); i++) {
Expand Down
4 changes: 2 additions & 2 deletions test/test_files/tinysnb/call/call.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ Binder exception: Cannot evaluate a.fName as a literal.
38
-STATEMENT CALL storage_info('knows') RETURN COUNT(*)
---- 1
84
80
-STATEMENT CALL storage_info('workAt') RETURN COUNT(*)
---- 1
26
22
Loading