[v1] Add HTTP TLS (issue #393) #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add environment variables for SSL configuration - Implement conditional SSL server startup based on configuration
- Added a way to configure cipher suites - Added a way to configure TLS min version
satk0
reviewed
Jan 20, 2025
| @@ -36,6 +36,13 @@ func main() { | |||
|
|
|||
| port, host := config.Port, config.Host | |||
| logstashUrl := config.LogstashUrl | |||
| enableSSL := config.EnableSSL == "TRUE" | |||
| sslCertDir := config.SSLCertDir | |||
There was a problem hiding this comment.
Shouldn't there be a sslCertFile instead of Dir, according to docs :
func ListenAndServeTLS(addr, certFile, keyFile string, handler Handler) error
| @@ -36,6 +36,13 @@ func main() { | |||
|
|
|||
| port, host := config.Port, config.Host | |||
| logstashUrl := config.LogstashUrl | |||
| enableSSL := config.EnableSSL == "TRUE" | |||
| sslCertDir := config.SSLCertDir | |||
| sslKeyDir := config.SSLKeyDir | |||
There was a problem hiding this comment.
Same as for certDir, shouldn't there be sslKeyFile provided?
| if err := appServer.ListenAndServe(); err != nil { | ||
| if enableSSL { | ||
| appServer.TLSConfig = tlsConfig | ||
| err = appServer.ListenAndServeTLS(sslCertDir, sslKeyDir) |
There was a problem hiding this comment.
Would be nice if you could actually test it. See my PR #401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.