Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): MaybeMockedConstructor returns T #1976

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(utils): MaybeMockedConstructor returns T #1976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(utils): MaybeMockedConstructor returns T 
At this point, `MaybeMockedConstructor` can return an empty object, causing the source type to be lost. This PR fixes this.
  • Loading branch information
@KostyaTretyak
KostyaTretyak committed Sep 21, 2020
commit 6710ff37f730dfa1fbd6f1b4e896da74df50e748
2 changes: 1 addition & 1 deletion src/utils/testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ interface MockWithArgs<T extends MockableFunction> extends jest.MockInstance<Ret

type MaybeMockedConstructor<T> = T extends new (...args: any[]) => infer R
? jest.MockInstance<R, ConstructorArgumentsOf<T>>
: {} // eslint-disable-line @typescript-eslint/ban-types
: T
type MockedFunction<T extends MockableFunction> = MockWithArgs<T> & { [K in keyof T]: T[K] }
type MockedFunctionDeep<T extends MockableFunction> = MockWithArgs<T> & MockedObjectDeep<T>
type MockedObject<T> = MaybeMockedConstructor<T> &
Expand Down