Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Allow kubevirt:default clusterRole to get,list kubevirts #11059

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[release-1.1] Allow kubevirt:default clusterRole to get,list kubevirts #11059

merged 3 commits into from
Jan 24, 2024

Conversation

fossedihelm
Copy link
Contributor

@fossedihelm fossedihelm commented Jan 22, 2024 •
edited
Loading

What this PR does / why we need it:
This is an manual cherry-pick of #11001 and #11050

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

Allow `kubevirt.io:default` clusterRole to get,list kubevirts

@fossedihelm
fix: Allow kubevirt:default clusterRole to get,list kubevirts
bc794d0 
Kubevirt resource is in category all.
`kubectl get all` or `virtctl permitted-devices` fails if
the user don't have the permissions to list Kubevirt resource.

Signed-off-by: fossedihelm <ffossemo@redhat.com>
@fossedihelm
fix: unexport constants if it is non necessary
ae43a36 
Signed-off-by: fossedihelm <ffossemo@redhat.com>
@fossedihelm
fix: restrict default cluster role to authenticated only users
79e568d 
Signed-off-by: fossedihelm <ffossemo@redhat.com>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 22, 2024
@fossedihelm fossedihelm marked this pull request as ready for review January 23, 2024 08:20
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
@fossedihelm
Copy link
Contributor Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@fossedihelm
Copy link
Contributor Author

/cc @acardace @0xFelix

@kubevirt-bot kubevirt-bot requested a review from 0xFelix January 23, 2024 08:21
@fossedihelm fossedihelm mentioned this pull request Jan 23, 2024
Closed
@0xFelix 0xFelix mentioned this pull request Jan 23, 2024
Closed
8 tasks
0xFelix
0xFelix approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@0xFelix
Copy link
Member

0xFelix commented Jan 24, 2024

/retest

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 24, 2024 •
edited
Loading

@fossedihelm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 79e568d link false /test pull-kubevirt-e2e-arm64-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@acardace
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acardace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@kubevirt-bot kubevirt-bot merged commit 67ce9b1 into kubevirt:release-1.1 Jan 24, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@dhiller dhiller Awaiting requested review from dhiller

@acardace acardace Awaiting requested review from acardace

@maiqueb maiqueb Awaiting requested review from maiqueb

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fossedihelm @kubevirt-bot @0xFelix @acardace