Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setup procedure to virtctl to allow people configuring preferences #6617

Open
rmohr opened this issue Oct 15, 2021 · 13 comments · May be fixed by #12759
Open

Add a setup procedure to virtctl to allow people configuring preferences #6617

rmohr opened this issue Oct 15, 2021 · 13 comments · May be fixed by #12759
Assignees
@xpivarc
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@rmohr
Copy link
Member

rmohr commented Oct 15, 2021

Is this a BUG REPORT or FEATURE REQUEST?:

/kind enhancement

What happened:

We have a few commands in virtctl which are guessing based on well known tools and file locations what people will most likely want to use when they run commands like virtcl vnc or virtcl ssh.

What you expected to happen:

We should add something like a virtctl config command which will do auto-detection and then ask people explicitly for their preferences and safe the result in a configfile.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • KubeVirt version (use virtctl version):
  • Kubernetes version (use kubectl version):
  • VM or VMI specifications:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@rmohr rmohr mentioned this issue Oct 15, 2021
Closed
@rmohr rmohr mentioned this issue Nov 25, 2021
Closed
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2022
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2022
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rmohr
Copy link
Member Author

rmohr commented Mar 14, 2022

/remove-lifecycle rotten
/lifecycle frozen
/reopen

@kubevirt-bot kubevirt-bot reopened this Mar 14, 2022
@kubevirt-bot
Copy link
Contributor

@rmohr: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/lifecycle frozen
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 14, 2022
@alicefr
Copy link
Member

alicefr commented Mar 3, 2023

/label good-first-issue

@kubevirt-bot kubevirt-bot added the good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. label Mar 3, 2023
@shivangnayar-dev
Copy link

can i be assigned this issue

@shivangnayar-dev
Copy link

can u help me where i can find the existing file?

@xpivarc
Copy link
Member

xpivarc commented Mar 21, 2023

/assign
@shivangnayar-crypto
All the relevant code should be in /pkg/virtctl/

@shivangnayar-dev
Copy link

should i create a new file named config.go under the pkg/virtctl directory and add the code there?

@shivangnayar-dev
Copy link

i have sent a pull request for config.go file kindly review it

@shivangnayar-dev shivangnayar-dev mentioned this issue Mar 27, 2023
Closed
@gaurangkudale
Copy link

Hi @rmohr,

I hope you are doing well.

I have a couple of questions regarding the configuration setup in KubeVirt:

  1. Is there any default configuration file that KubeVirt refers to when executing commands?
  2. If a user wants to use an existing configuration file, should that file exist by default, or would it need to be created or specified manually?

This was referenced Sep 6, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xpivarc xpivarc

Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adding virtctl config cmd gaurangkudale/kubevirt
Adding virtctl config cmd
6 participants
@rmohr @alicefr @kubevirt-bot @xpivarc @shivangnayar-dev @gaurangkudale