Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s enables structured logging more and more, consider switching to their structured logger #5932

Open
rmohr opened this issue Jun 24, 2021 · 7 comments
Open

k8s enables structured logging more and more, consider switching to their structured logger #5932

rmohr opened this issue Jun 24, 2021 · 7 comments
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rmohr
Copy link
Member

rmohr commented Jun 24, 2021

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:

We use our own structured logger and we do quite some magic to get all messages into the logger (glog, klog, and go-log).
Mostly because k8s did not use structured logging.

What you expected to happen:

k8s has for quite some time a structured logging WG and they make fast progress. At some point we can switch to the new structured logger from k8s and consolidate it.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • KubeVirt version (use virtctl version):
  • Kubernetes version (use kubectl version):
  • VM or VMI specifications:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@rmohr
Copy link
Member Author

rmohr commented Jun 24, 2021

@davidvossel FYI

@phoracek phoracek added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 30, 2021
@ansijain
Copy link
Contributor

/assign

@ansijain ansijain removed their assignment Oct 11, 2021
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2022
@rmohr
Copy link
Member Author

rmohr commented Jan 10, 2022

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2022
@rmohr
Copy link
Member Author

rmohr commented Jan 10, 2022

/lifecycle frozen

@kubevirt-bot kubevirt-bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 10, 2022
@alicefr
Copy link
Member

alicefr commented Mar 3, 2023

@ansijain I don't see any linked PR to this issue, did you have the chance to work on this?

@alicefr
Copy link
Member

alicefr commented Mar 3, 2023

/label good-first-issue

@kubevirt-bot kubevirt-bot added the good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. label Mar 3, 2023
@victortoso victortoso mentioned this issue Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Identifies an issue that has been specifically created or selected for first-time contributors. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@phoracek @rmohr @alicefr @kubevirt-bot @ansijain