Fix(health): terraform conflict #3419
Conversation
Signed-off-by: Evan Li <evan.li97@outlook.com>
evanli18
requested review from
hongchaodeng,
wonderflow and
leejanee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
=======================================
Coverage 39.25% 39.26%
=======================================
Files 267 267
Lines 26415 26416 +1
=======================================
+ Hits 10370 10372 +2
- Misses 14360 14361 +1
+ Partials 1685 1683 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if configuration.Status.Apply.State != terraformtypes.Available { | ||
| if appRev.Name != configuration.GetLabels()["app.oam.dev/appRevision"] || | ||
| configuration.Status.Apply.State != terraformtypes.Available || | ||
| configuration.Status.ObservedGeneration != configuration.Generation { |
There was a problem hiding this comment.
Add an && logic to check whether configuration.Status.ObservedGeneration is set.
There was a problem hiding this comment.
That good. here we also need to compare apprev
There was a problem hiding this comment.
What will happen if we don't compare apprev?
There was a problem hiding this comment.
In kubebuilder, client.Get always gets data from the cache, so client.Get gets data from the cache immediately after applying object.
Signed-off-by: Evan Li evan.li97@outlook.com
Description of your changes
"Fixes #3355": Fix health state of the terrafrom comp