Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the artifact download link on the Pipeline run page #3007

Merged

Conversation

LinuxSuRen
Copy link
Member

What type of PR is this?

/kind feature
/area devops

What this PR does / why we need it:

It's not good to use any Jenkins API directly.

See kubesphere/ks-devops#479

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none kind/feature Categorizes issue or PR as related to a new feature. area/devops size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
@LinuxSuRen
Copy link
Member Author

LinuxSuRen commented Mar 18, 2022

Below is the image of this PR:

surenpi/ks-console:latest@sha256:e54caf1d41769b57a995e498c360e2660c82ed1f91520d452bb9d2f53b0a4246

@LinuxSuRen LinuxSuRen force-pushed the change-artifact-download-link branch from 7728810 to 4dce0bf Compare March 18, 2022 06:13
@LinuxSuRen LinuxSuRen changed the title WIP: Change the artifact download link on the Pipeline run page Change the artifact download link on the Pipeline run page Mar 18, 2022
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2022
@LinuxSuRen LinuxSuRen requested review from harrisonliu5 and leoendless and removed request for harrisonliu5 March 18, 2022 06:36
@LinuxSuRen LinuxSuRen force-pushed the change-artifact-download-link branch from 4dce0bf to aa4880e Compare March 18, 2022 06:39
@harrisonliu5
Copy link
Contributor

/assign @weili520

@weili520
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c6b4e8ef9e59a3ee9699276defca390c0c505977

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@ks-ci-bot ks-ci-bot merged commit d40d712 into kubesphere:master Mar 21, 2022
@LinuxSuRen LinuxSuRen deleted the change-artifact-download-link branch March 21, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants