Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the version of scheduler config and use MultiPoint to simplify them #680

Merged
merged 1 commit into from
Jan 4, 2024
Merged

docs: update the version of scheduler config and use MultiPoint to simplify them #680

merged 1 commit into from
Jan 4, 2024

Conversation

lianghao208
Copy link
Member

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Since #670 has been merged, we need to update scheduler config version from v1beta3 to v1

Which issue(s) this PR fixes:

Fixes #673

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 28, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins ready!

Name Link
🔨 Latest commit 632e25c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/6580004dfc5e3d0008c1f7aa
😎 Deploy Preview https://deploy-preview-680--kubernetes-sigs-scheduler-plugins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2023
@lianghao208 lianghao208 changed the title doc: update the version of scheduler config and use MultiPoint to simplify them docs: update the version of scheduler config and use MultiPoint to simplify them Nov 28, 2023
@Huang-Wei
Copy link
Contributor

@lianghao208 we may on-hold this due to recently found bug in upstream kubernetes/kubernetes#122066

@lianghao208 lianghao208 mentioned this pull request Dec 15, 2023
Closed
@lianghao208
Copy link
Member Author

lianghao208 commented Dec 15, 2023 •
edited
Loading

@lianghao208 we may on-hold this due to recently found bug in upstream kubernetes/kubernetes#122066

@Huang-Wei friendly ping, the upstream bug has been fixed

@panpan0000
Copy link

Hi, @lianghao208
maybe you can also address a few files in docs ?
image

PS: I've closed my PR https://github.com/kubernetes-sigs/scheduler-plugins/pull/688/files

@lianghao208
doc: doc/manifest update, use v1 as the version of all scheduler conf…
632e25c 
…ig yamls, use MultiPoint to simplify configuring each plugin.
@lianghao208
Copy link
Member Author

Hi, @lianghao208 maybe you can also address a few files in docs ? image

PS: I've closed my PR https://github.com/kubernetes-sigs/scheduler-plugins/pull/688/files

@panpan0000 Thanks for reminding me, I've updated these files.

@Huang-Wei
Copy link
Contributor

Let's merge it for now, and we will bump the version before releasing to pick up the changes of kubernetes/kubernetes#122066

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, lianghao208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit c0a200b into kubernetes-sigs:master Jan 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: manifest updates to use v1 as scheduler config and multipoint
4 participants
@lianghao208 @Huang-Wei @panpan0000 @k8s-ci-robot