Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the retryDelayMinutes deprecation notice with the standard form #3204

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Align the retryDelayMinutes deprecation notice with the standard form #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/kueue/v1beta1/admissioncheck_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ type AdmissionCheckSpec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="field is immutable"
ControllerName string `json:"controllerName"`

// RetryDelayMinutes **deprecated** specifies how long to keep the workload suspended after
// RetryDelayMinutes specifies how long to keep the workload suspended after
// a failed check (after it transitioned to False). When the delay period has passed, the check
// state goes to "Unknown". The default is 15 min.
// The default is 15 min.
// +optional
// +kubebuilder:default=15
// Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
RetryDelayMinutes *int64 `json:"retryDelayMinutes,omitempty"`

// Parameters identifies a configuration with additional parameters for the
Expand Down
4 changes: 2 additions & 2 deletions charts/kueue/templates/crd/kueue.x-k8s.io_admissionchecks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ spec:
retryDelayMinutes:
default: 15
description: |-
RetryDelayMinutes **deprecated** specifies how long to keep the workload suspended after
RetryDelayMinutes specifies how long to keep the workload suspended after
a failed check (after it transitioned to False). When the delay period has passed, the check
state goes to "Unknown". The default is 15 min.
The default is 15 min.
Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
format: int64
type: integer
required:
Expand Down
4 changes: 2 additions & 2 deletions config/components/crd/bases/kueue.x-k8s.io_admissionchecks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ spec:
retryDelayMinutes:
default: 15
description: |-
RetryDelayMinutes **deprecated** specifies how long to keep the workload suspended after
RetryDelayMinutes specifies how long to keep the workload suspended after
a failed check (after it transitioned to False). When the delay period has passed, the check
state goes to "Unknown". The default is 15 min.
The default is 15 min.
Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.
format: int64
type: integer
required:
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/reference/kueue.v1beta1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,10 @@ not necessarily a Kubernetes Pod or Deployment name. Cannot be empty.</p>
<code>int64</code>
</td>
<td>
<p>RetryDelayMinutes <strong>deprecated</strong> specifies how long to keep the workload suspended after
<p>RetryDelayMinutes specifies how long to keep the workload suspended after
a failed check (after it transitioned to False). When the delay period has passed, the check
state goes to &quot;Unknown&quot;. The default is 15 min.
The default is 15 min.</p>
Deprecated: retryDelayMinutes has already been deprecated since v0.8 and will be removed in v1beta2.</p>
</td>
</tr>
<tr><td><code>parameters</code><br/>
Expand Down