Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Feature/2.8 backports for 2.8.1 #3911

Merged
merged 4 commits into from
Dec 26, 2018
Merged

More Feature/2.8 backports for 2.8.1 #3911

merged 4 commits into from
Dec 26, 2018

Conversation

verwilst
Copy link
Contributor

@verwilst verwilst commented Dec 18, 2018 •
edited
Loading

Backport #3845, #3908 and #3839 . Update k8s to 1.12.4

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2018
@k8s-ci-robot k8s-ci-robot requested review from ant31 and mirwan December 18, 2018 15:55
@woopstar
Copy link
Member

ci check this

@verwilst
Copy link
Contributor Author

Backported #3908 as per @woopstar's request. Updated to k8s 1.12.4 release.

@mattymo
Copy link
Contributor

mattymo commented Dec 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2018
@woopstar woopstar self-assigned this Dec 25, 2018
@riverzhang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: riverzhang, verwilst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2ac1c75 into kubernetes-sigs:release-2.8 Dec 26, 2018
@verwilst verwilst deleted the feature/2.8-backports branch January 21, 2019 11:23
spisarski pushed a commit to cablelabs/kubespray that referenced this pull request Feb 11, 2019
@verwilst @spisarski
More Feature/2.8 backports for 2.8.1 (kubernetes-sigs#3911)
742681f 
* Move node-cidr-mask-size to ControllerManagerextraArgs (kubernetes-sigs#3845)

* Fix apiServerCertSANs in kubeadm config file (kubernetes-sigs#3839)

* Backport kubernetes-sigs#3908

* Update kubernetes to 1.12.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant31 ant31 Awaiting requested review from ant31

@mirwan mirwan Awaiting requested review from mirwan

Assignees

@mattymo mattymo

@woopstar woopstar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@verwilst @woopstar @mattymo @riverzhang @k8s-ci-robot @pasqualet