Set default value for disable_shared_pid #1710
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
added
cncf-cla: yes
| @@ -14,6 +14,7 @@ KUBELET_HOSTNAME="--hostname-override={{ kube_override_hostname }}" | |||
| --pod-infra-container-image={{ pod_infra_image_repo }}:{{ pod_infra_image_tag }} \ | |||
| --kube-reserved cpu={{ kubelet_cpu_limit }},memory={{ kubelet_memory_limit|regex_replace('Mi', 'M') }} \ | |||
| --node-status-update-frequency={{ kubelet_status_update_frequency }} \ | |||
| --docker-disable-shared-pid={{ kubelet_disable_shared_pid }} \ | |||
There was a problem hiding this comment.
Please also update kubeadm env file as well in the same directory.
|
This change is being reverted with kubernetes 1.8 kubernetes/kubernetes#51634 . I'm not sure on the appropriate way to handle this setting. |
|
Yeah..pid namespace sharing is enabled by default until 1.6 and disabled in 1.7, and then enabled again in 1.8. Actually, we wasted one day for finding this when we upgraded from 1.6 to 1.7. This patch will keep the configuration enabled for others who don't care about it. |
PID namespace sharing is disabled only in Kubernetes 1.7. Explicitily enabling it by default could help reduce unexpected results when upgrading to or downgrading from 1.7.
|
ci check this |
Sharing PID namespace for Docker is disabled by default only in
Kubernetes 1.7. Explicitily enabling it by default could help reduce
unexpected results when upgrading to or downgrading from 1.7.