Adapt checksums and versions to new hashes updater #11890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XXL
|
/ok-to-test
|
k8s-ci-robot
added
the
ok-to-test
|
/label ci/extended |
|
@VannTen: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/label tide/merge-method-merge |
k8s-ci-robot
added
the
tide/merge-method-merge
|
/label ci-extended |
mzaian
reviewed
Jan 15, 2025
|
/retest |
VannTen
force-pushed
the
download_graphql_checksums_2
branch
from
59e8f8f to
b2e8473
Compare
k8s-ci-robot
added
the
needs-rebase
VannTen
force-pushed
the
download_graphql_checksums_2
branch
from
b2e8473 to
0b9d9bb
Compare
k8s-ci-robot
removed
the
needs-rebase
VannTen
force-pushed
the
download_graphql_checksums_2
branch
2 times, most recently
from
bce30fc to
2d64093
Compare
With the refactored script, this would try to download those releases each time.
VannTen
force-pushed
the
download_graphql_checksums_2
branch
3 times, most recently
from
6d54849 to
6619a62
Compare
The versions are nearly all .0 because of the gvisor release scheme. This means they need to be quoted in yaml to be considered strings. Special casing by removing the .0 make tooling more complicated, and it does not gain us anything apart from a nicer looking file (I guess). So just use the version of upstream gvisor and quote it.
VannTen
force-pushed
the
download_graphql_checksums_2
branch
4 times, most recently
from
7fada99 to
616dd35
Compare
|
/label tide/merge-method-merge |
also remove the version key in all dict in downloads since it's not used anywhere.
Allow the use of different hashes, as support by the get_url Ansible module. Change the variable name accordingly to 'checksum' since it's not exclusively sha256 anymore.
VannTen
force-pushed
the
download_graphql_checksums_2
branch
from
616dd35 to
4f55d36
Compare
VannTen
force-pushed
the
download_graphql_checksums_2
branch
from
4f55d36 to
5f650e4
Compare
|
So, this is passing CI 🎉 What I want to add before merging this:
|
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
VannTen
force-pushed
the
download_graphql_checksums_2
branch
3 times, most recently
from
92f52b1 to
a3e081f
Compare
Only check version that we previously prefixed with 'v'. This commit should be reverted as soon as 2.28 is released.
VannTen
force-pushed
the
download_graphql_checksums_2
branch
from
a3e081f to
815bc6e
Compare
mzaian
approved these changes
Jan 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This (WIP) adapt Kubespray checksums and version to work with the new hashes updater.
I'm pushing this as draft so reviewers of the hashes updaters can test it.
This is pretty invasive, as you can see, mostly because of removing the v-prefix in version (this originates from the design of the updater script, but I've been going with it for consistency).
Missing:
Which issue(s) this PR fixes:
Special notes for your reviewer:
I'm putting this as ci/extended to avoid breaking stuff
This might be hard to backport, which might preclude automatic PR for hash updates on the releases branches.
Does this PR introduce a user-facing change?: