Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop explicit k8s_cluster group in CI inventory #11858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop explicit k8s_cluster group in CI inventory #11858

wants to merge 1 commit into from

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 6, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This removes compatibility with releases below 2.27.0, now that it has
been released and that we're testing upgrades against it.

Functional revert of b5464af now that 2.27.0 is released.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from yankay January 6, 2025 08:34
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@VannTen
Copy link
Contributor Author

VannTen commented Jan 6, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 6, 2025
@VannTen
Copy link
Contributor Author

VannTen commented Jan 6, 2025

/retest

@VannTen VannTen force-pushed the ci_cleanup/no_need_for_k8s_cluster_group branch from 946ec90 to 6c74cdd Compare January 6, 2025 08:57
@ant31
Copy link
Contributor

ant31 commented Jan 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@VannTen
Copy link
Contributor Author

VannTen commented Jan 6, 2025

I don't get why this would trigger the kube_pods_subnet undefined stuff
(I see why that'd be a problem, but not why this only happens now with that revert and not before)

Let's retest in case this is something else:

/retest

@VannTen VannTen force-pushed the ci_cleanup/no_need_for_k8s_cluster_group branch from 6c74cdd to 3742442 Compare January 7, 2025 09:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@VannTen
Copy link
Contributor Author

VannTen commented Jan 7, 2025

Ok, so the reason not having the k8s_cluster group trigger the undefined is this line in the inventory sample:

inventory/sample/group_vars/k8s_cluster/k8s-cluster.yml:kube_pods_subnet: 10.233.64.0/18

That stuff needs to die, fast :))))

@VannTen VannTen mentioned this pull request Jan 16, 2025
Open
@VannTen
Drop explicit k8s_cluster group in CI inventory
b7eb112 
This removes compatibility with releases below 2.27.0, now that it has
been released and that we're testing upgrades against it.
@VannTen VannTen force-pushed the ci_cleanup/no_need_for_k8s_cluster_group branch from 3742442 to b7eb112 Compare January 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@yankay yankay Awaiting requested review from yankay

Assignees

@ant31 ant31

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VannTen @k8s-ci-robot @ant31