Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove openstack feature gate and legacy in-tree provider documentation #10879

Closed
wants to merge 1 commit into from
Closed

Remove openstack feature gate and legacy in-tree provider documentation #10879

wants to merge 1 commit into from

Conversation

LarssonOliver
Copy link
Contributor

@LarssonOliver LarssonOliver commented Feb 5, 2024 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Removes documentation about the legacy in-tree OpenStack provider (removed 1.26) and the following feature gates:

Specifying the feature gates as suggested by current documentation causes the kubelet to error out.

Which issue(s) this PR fixes:

Fixes #10250

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 5, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LarssonOliver / name: Oliver Larsson (453ea34)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @LarssonOliver!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LarssonOliver
Once this PR has been reviewed and has the lgtm label, please assign mirwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @LarssonOliver. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 5, 2024
@floryut
Copy link
Member

floryut commented Feb 5, 2024

Conflict with #10448

@floryut floryut mentioned this pull request Feb 5, 2024
Merged
@LarssonOliver
Copy link
Contributor Author

You're right. Sorry about that.

The in-tree provider documentation is probably not needed anymore either which that one does not cover.

I'll close this and open a new PR that only covers that.

@LarssonOliver
Copy link
Contributor Author

Redid this pr without the conflict in #10889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubelet not starting with external cloud provider OpenStack on version 1.26.5
3 participants
@LarssonOliver @k8s-ci-robot @floryut