Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multus Daemonset does not configure a priorityClassName #11304

Closed
Mosibi opened this issue Jun 18, 2024 · 2 comments
Closed

Multus Daemonset does not configure a priorityClassName #11304

Mosibi opened this issue Jun 18, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Mosibi
Copy link
Contributor

Mosibi commented Jun 18, 2024

What happened?

The Multus Daemonset does not configure a priorityClassName like other CNI's, which can cause the Multus Pod to be preempted in favor of less important Pods

What did you expect to happen?

Multus Pods should configure a priorityClassName, preferable system-node-critical like other CNI's

How can we reproduce it (as minimally and precisely as possible)?

The command kubectl get pods -A -o json | jq '.items[] | select (.spec.priorityClassName == null) | "Namespace: " + .metadata.namespace + " Name: " + .metadata.name' which lists Pods that do not have a priorityClassName returns "multus" pods.

OS

not important

Version of Ansible

not important

Version of Python

not important

Version of Kubespray (commit)

24dc4ce

Network plugin used

calico

Full inventory with variables

not important

Command used to invoke ansible

not important

Output of ansible run

not important

Anything else we need to know

I will create a pull-request to add priorityClassName support for Multus

@Mosibi Mosibi added the kind/bug Categorizes issue or PR as related to a bug. label Jun 18, 2024
@ThisIsQasim
Copy link
Contributor

This has been resolved by #11434

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2024
@Mosibi Mosibi closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants