Always --pull during docker build #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign |
|
/lgtm |
|
@dnardo can you merge and then possibly publish a new git tag (and build a new release)? I don't have write access on this repo. |
ixdy
force-pushed
the
docker-build-always-pull
branch
from
4595ff0 to
6017b66
Compare
|
also updated so we pull the build image; this way we'll get the latest 1.7 go patch release too. |
|
@ixdy done and v2.0.2 is now built. |
|
@dnardo where? I don't see a v2.0.2 tag in git or on gcr.io. (also, a fix for CVE-2017-9526 just went into debian-iptables-amd64:v7, so it's good that you haven't published anything anywhere yet. if you do push an image, please be sure to rebuild first.) |
|
That is because I don't permission to push to gcr. I hadn't notice that last night when I pushed it. |
|
Ok done. Really :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without --pull, it's possible to use old base images which may have fixed vulnerabilities upstream.
x-ref kubernetes/kubernetes#47386
After merging this, we should probably create a new tag and then rebuild the image.