Skip to content
This repository has been archived by the owner on Apr 21, 2019. It is now read-only.

Address outstanding DNS review comments in #26694 #48

Closed
irfanurrehman opened this issue Oct 30, 2017 · 11 comments
Closed

Address outstanding DNS review comments in #26694 #48

irfanurrehman opened this issue Oct 30, 2017 · 11 comments
Labels
area/federation milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. sig/multicluster Categorizes an issue or PR as relevant to sig-multicluster. team/control-plane (deprecated - do not use)

Comments

@irfanurrehman
Copy link
Contributor

Issue by quinton-hoole
Monday Jun 06, 2016 at 23:42 GMT
Originally opened as kubernetes/kubernetes#26921


See kubernetes/kubernetes#26694 for details. Specifically:

  1. Don't call ensureDnsRecords() if the DNS provider has not been initialized.
  2. Don't discard errors returned by getClusterZoneNames()

cc: @mfanjie FYI

@irfanurrehman irfanurrehman added area/federation milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. sig/multicluster Categorizes an issue or PR as relevant to sig-multicluster. team/control-plane (deprecated - do not use) labels Oct 30, 2017
@irfanurrehman
Copy link
Contributor Author

Comment by goltermann
Tuesday Sep 06, 2016 at 21:03 GMT


@quinton-hoole this is P2...time to punt to v1.5?

@irfanurrehman
Copy link
Contributor Author

Comment by quinton-hoole
Tuesday Sep 06, 2016 at 21:29 GMT


@golterman Yes, 1.5 is fine. I seem to have lost the authority to update the Milestone? Did you perhaps change permissions?

@irfanurrehman
Copy link
Contributor Author

Comment by goltermann
Tuesday Sep 06, 2016 at 21:38 GMT


I moved it - no idea why you wouldn't have permission on the kubernetes repo.

@irfanurrehman
Copy link
Contributor Author

Comment by dims
Tuesday Nov 15, 2016 at 21:32 GMT


ok to move this to 1.6? please holler if not appropriate

@irfanurrehman
Copy link
Contributor Author

Comment by quinton-hoole
Friday Nov 18, 2016 at 16:10 GMT


Reassigning to @nikhiljindal in case he wants to address this in future. @mfanjie would also be a suitable candidate.

@irfanurrehman
Copy link
Contributor Author

Comment by ethernetdan
Monday Mar 13, 2017 at 22:30 GMT


Moving to 1.7 as late to happen in 1.6. Feel free to switch back if this is incorrect.

@irfanurrehman
Copy link
Contributor Author

Comment by marun
Monday Jun 12, 2017 at 20:47 GMT


Not a release blocker for 1.7.

@irfanurrehman
Copy link
Contributor Author

Comment by k8s-merge-robot
Saturday Sep 09, 2017 at 08:01 GMT


[MILESTONENOTIFIER] Milestone Removed

@nikhiljindal @quinton-hoole

Important:
This issue was missing labels required for the v1.8 milestone for more than 7 days:

kind: Must specify exactly one of [kind/bug, kind/cleanup, kind/feature].
priority: Must specify exactly one of [priority/critical-urgent, priority/important-longterm, priority/important-soon].

Removing it from the milestone.

Additional instructions available here The commands available for adding these labels are documented here

@irfanurrehman
Copy link
Contributor Author

cc @quinton-hoole

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@shashidharatd
Copy link
Contributor

The issues have been addressed in current code after it was service controller code was refactored. So this issue is not relevant anymore
/close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/federation milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. sig/multicluster Categorizes an issue or PR as relevant to sig-multicluster. team/control-plane (deprecated - do not use)
Projects
None yet
Development

No branches or pull requests

4 participants