kubernetes-addons: cluster/saltbase/salt/kube-addons changed to cluster/addons/addon-manager #927
Conversation
|
Caused by kubernetes/kubernetes#23600 |
ingvagabund
force-pushed
the
fix-kubernetes-addons-namespace-yaml-localtion
branch
from
d9b4426 to
e1dadec
Compare
ingvagabund
changed the title
|
Entire directory has changed: |
ingvagabund
changed the title
cluster/saltbase/salt/kube-addons/namespace.yaml -> cluster/addons/addon-manager/namespace.yaml
ingvagabund
force-pushed
the
fix-kubernetes-addons-namespace-yaml-localtion
branch
from
e1dadec to
de841e9
Compare
|
+1, this works for me thanks for the patch |
|
@ingvagabund let me know when you do not think this is a WIP |
ingvagabund
changed the title
|
@eparis right now |
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| - name: Make sure the system services namespace exists | |||
| get_url: | |||
| url=https://raw.githubusercontent.com/GoogleCloudPlatform/kubernetes/master/cluster/saltbase/salt/kube-addons/namespace.yaml | |||
| url=https://raw.githubusercontent.com/kubernetes/kubernetes/master/{{ kube_addons_download_source_dir }}/namespace.yaml | |||
| dest="{{ kube_config_dir }}/addons/" | |||
There was a problem hiding this comment.
dest is hard coding to /opt/namespace.yaml in kube-addons.sh, it need to adjust accordingly.
https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/kube-addons.sh#L68
There was a problem hiding this comment.
@mikedanese , WDYT? Maybe kube-addons.sh.j2 and replace the /opt/namespace.yaml with {{ kube-addons-namespace-location }}/namespace.yaml or similar buzzword?
There was a problem hiding this comment.
Why can't you just run addon manager in a static pod? that file exists inside gcr.io/google-containers/kube-addon-manager
There was a problem hiding this comment.
I have no idea. Maybe, it is "just" a coincidence and the /opt/namespace.yaml path is correct.
…es-retired#927) cluster/saltbase/salt/kube-addons/namespace.yaml -> cluster/addons/addon-manager/namespace.yaml
cluster/saltbase/salt/kube-addons/namespace.yaml -> cluster/addons/addon-manager/namespace.yaml