Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Rebase reshceduler to distroless #3010

Closed
wants to merge 1 commit into from
Closed

Rebase reshceduler to distroless #3010

wants to merge 1 commit into from

Conversation

yuwenma
Copy link

@yuwenma yuwenma commented Apr 11, 2019

This is part of the effort described in kep kubernetes/enhancements#900
Comparing to busybox, Distroless can mitigate the influence due to CVE issues.

Since the rescheduler doesn't have heavy dependencies (only calls rescheduler), this should be a safe move.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@yuwenma
Copy link
Author

yuwenma commented Apr 11, 2019

/assign @yguo0905

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuwenma
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bsalamat

If they are not already assigned, you can assign the PR to them by writing /assign @bsalamat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Author

yuwenma commented Apr 11, 2019

/assign @bsalamat

Copy link
Contributor

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuwenma Rescheduler is deprecated and decommissioned since K8s 1.12. K8s priority and preemption is the new mechanism that removed the need to have Rescheduler. So, we no longer deploy Rescheduler. Given that, do we still need this change?

@yuwenma
Copy link
Author

yuwenma commented Apr 11, 2019

@bsalamat I see. If so, I'll close the PR (the rebasing is targeting the timeline for the v1.15 release). Thanks for the explanation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants