File flakes for presubmit runs #1281
Conversation
| { | ||
| bucket: "kubernetes-jenkins", | ||
| pathParts: []interface{}{"logs", "kubernetes-gce-e2e", 1458}, | ||
| expect: "https://www.googleapis.com/storage/v1/b/kubernetes-jenkins/o?prefix=%2Flogs%2Fkubernetes-gce-e2e%2F1458%2F", |
There was a problem hiding this comment.
@freehan can you verify the correctness of this test?
There was a problem hiding this comment.
It looks fine to me.
I think I saw a golang gcs client somewhere. Why not use that one instead of writing a new one? I almost pull it last time when I was doing the gcs list stuff.
There was a problem hiding this comment.
next time, maybe I will. Already got this working though :)
On Tue, Jun 28, 2016 at 3:13 PM, Minhan Xia notifications@github.com
wrote:
In test-utils/utils/bucket_test.go
#1281 (comment):+package utils
+
+import (
- "testing"
+)
+func TestExpandListURL(t *testing.T) {
- table := []struct {
bucket stringpathParts []interface{}expect string- }{
{bucket: "kubernetes-jenkins",pathParts: []interface{}{"logs", "kubernetes-gce-e2e", 1458},expect: "https://www.googleapis.com/storage/v1/b/kubernetes-jenkins/o?prefix=%2Flogs%2Fkubernetes-gce-e2e%2F1458%2F",It looks fine to me.
I think I saw a golang gcs client somewhere. Why not use that one instead
of writing a new one? I almost pull it last time when I was doing the gcs
list stuff.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1281/files/cb8cb59b65946addb0eb0514c835879c0634316a#r68853952,
or mute the thread
https://github.com/notifications/unsubscribe/AAnglvndl0tzYlJp9-CSm0xB3ShJh6uiks5qQZyEgaJpZM4JASOK
.
lavalamp
changed the title
|
OK, in my test setup, this works-- it made https://github.com/lavalamp/issue-testing/issues/150#issuecomment-229750994 after a passing run of the e2e test on kubernetes/kubernetes#27898 |
| // LogDir is the directory of the pr builder jenkins | ||
| PRLogDir = "pr-logs" | ||
| // PullLogDir is the directory of the pr builder jenkins | ||
| PullLogDir = "pr-logs" |
There was a problem hiding this comment.
Changed my mind partway through (it's added in this PR, just changed in the second commit).
|
Fix pushed, PTAL |
|
LGTM |
|
\o/ |
File flakes for presubmit runs
Still working on this-- mostly clean up at the moment.