This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Autoscaler: Super hacky workaround for GCE provider crashloop #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to kubernetes/kubernetes#27821. Borrows the necessary piece of kubernetes/kubernetes#27741 to parse the gce.conf. Also opened kubernetes-retired#1251 to fix Godeps correctly
|
thankfully for you we don't have any tests in contrib to keep you from doing such things :) |
|
LGTM |
|
@eparis: Whew. :) |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jun 22, 2016
Automatic merge from submit-queue Bump Cluster Autoscaler to 0.2.1 Workaround for #27821. Contains kubernetes-retired/contrib#1252 cc: @piosz @fgrzadkowski @jszczepkowski
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…ical-fix-27821 Autoscaler: Super hacky workaround for GCE provider crashloop
mwielgus
added a commit
to kubernetes/autoscaler
that referenced
this pull request
Apr 18, 2017
…ical-fix-27821 Autoscaler: Super hacky workaround for GCE provider crashloop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to kubernetes/kubernetes#27821. Borrows the necessary piece of kubernetes/kubernetes#27741 to parse the
gce.conf.Also opened #1251 to fix Godeps correctly.
Forgive me.