Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default enabled admission control plugins #9784

Merged
merged 2 commits into from
Sep 24, 2018
Merged

Add default enabled admission control plugins #9784

merged 2 commits into from
Sep 24, 2018

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Aug 8, 2018

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 8, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e858f09

https://deploy-preview-9784--kubernetes-io-master-staging.netlify.com

CaoShuFeng
CaoShuFeng reviewed Aug 8, 2018
View reviewed changes
content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated
```
NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota
```
The `Priority` admission plugin is enabled by default when using `--enable-admission-plugins`. If using `--admission-control` to fully specify the set of admission plugins, the `Priority` admission plugin should be added if using the `PodPriority` feature, which is enabled by default in 1.11.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--admission-control is deprecated.
Not sure we want to describe a deprecated flag in document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaoShuFeng Simplified.

@ChiuWang ChiuWang force-pushed the defalutEnabledAdmissionPlugin branch from 8eb380d to 053eb96 Compare August 8, 2018 06:59
@zparnold
Copy link
Member

zparnold commented Aug 8, 2018

@charrywanganthony Is everything here listed the default for 1.11? Are we creating a way to maintain these through their lifecycle?

@ChiuWang
Copy link
Contributor Author

ChiuWang commented Aug 9, 2018

@zparnold I write a function to to maintain the list in kube-apiserver -h infos k8s/pr #67011. When 67011 merged, we can get the list from --enable-admission-plugins from kube-apiserver -h. Maybe i should add a tip there to tell readers use kube-apiserver -h to get informations, and this should be merged after 67011 merged in this way.

@ChiuWang ChiuWang force-pushed the defalutEnabledAdmissionPlugin branch from 053eb96 to 0f34012 Compare August 23, 2018 05:28
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2018
@ChiuWang
Copy link
Contributor Author

Kubernetes/pr #67011 has been merged. @zparnold WDYT about this pr now?

zacharysarah
zacharysarah suggested changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charrywanganthony Good start! ✨ Some small changes, otherwise looks good from a docs standpoint.

content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated
@@ -81,6 +81,20 @@ The Kubernetes API server flag `disable-admission-plugins` takes a comma-delimit
kube-apiserver --disable-admission-plugins=PodNodeSelector,AlwaysDeny ...
```

## What plugins are enabled by default?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/What/Which

content/en/docs/reference/access-authn-authz/admission-controllers.md Outdated
@@ -81,6 +81,20 @@ The Kubernetes API server flag `disable-admission-plugins` takes a comma-delimit
kube-apiserver --disable-admission-plugins=PodNodeSelector,AlwaysDeny ...
```

## What plugins are enabled by default?

You can get the enabled admission plugins in result of:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this line with:

To see which admission plugins are enabled:

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 777d075 into kubernetes:master Sep 24, 2018
@ChiuWang ChiuWang deleted the defalutEnabledAdmissionPlugin branch September 27, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaoShuFeng CaoShuFeng CaoShuFeng left review comments

@zacharysarah zacharysarah zacharysarah approved these changes

@erictune erictune Awaiting requested review from erictune

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChiuWang @k8sio-netlify-preview-bot @zparnold @zacharysarah @k8s-ci-robot @CaoShuFeng