Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Memory Manager goes GA #48578

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Oct 28, 2024

Description

List and describe the changes done
for Memory manager since beta and made it GA ready.

Issue

kubernetes/enhancements#1769

Closes: #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim October 28, 2024 16:50
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Tal-or!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 28, 2024

/hold
WIP a placeholder PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 18c34f7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/674c740643568e0008324d69
😎 Deploy Preview https://deploy-preview-48578--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Hi @Tal-or, Since the Memory Manager is GA in k8s v1.32, we should consider the dev-1.32 branch as the target branch rather than the main branch for this pull request.

@Shubham82
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 28, 2024
@Tal-or Tal-or changed the base branch from main to dev-1.32 October 29, 2024 06:45
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 124a0d9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/674c7347bd4b220008f7a3bd

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Oct 29, 2024

Hi @Tal-or, Since the Memory Manager is GA in k8s v1.32, we should consider the dev-1.32 branch as the target branch rather than the main branch for this pull request.

My bad. Done. Thank you!

@kannon92
Copy link
Contributor

kannon92 commented Nov 3, 2024

We should have another PR where we update the documentation for memory manager to mention that it is stable.

Can you please open up a separate one?

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 4, 2024

We should have another PR where we update the documentation for memory manager to mention that it is stable.

Can you please open up a separate one?

Sure, thank you.
We can use this one #48494 which already got open in advanced

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial sig-node review

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 1, 2024
@Tal-or Tal-or changed the base branch from dev-1.32 to main December 1, 2024 14:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2024
List and describe the changes done
for Memory manager since beta and made it GA ready.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 1, 2024

Because of #48578 (comment) /lgtm cancel

Done, thank you!

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 1, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2024
@windsonsea
Copy link
Member

/remove-language fr it ja pl ru zh

@k8s-ci-robot k8s-ci-robot removed language/fr Issues or PRs related to French language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pl Issues or PRs related to Polish language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language labels Dec 2, 2024
@windsonsea
Copy link
Member

/remove-area localization

@k8s-ci-robot k8s-ci-robot removed the area/localization General issues or PRs related to localization label Dec 2, 2024
@sftim
Copy link
Contributor

sftim commented Dec 2, 2024

Looks good to merge as a draft

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0aebb921153d44e899c871dfd10179358d909046

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 88bd54b into kubernetes:main Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

10 participants