Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog on "Ensure secret pulled images" feature #47053

Closed

Conversation

sairameshv
Copy link
Member

Place holder PR for a blog on the Ensure secret pulled images feature

Reference: kubernetes/enhancements#2535

/cc @haircommander

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mrbobbytables for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 079672c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/669a61b7e431dc00083da9b4
😎 Deploy Preview https://deploy-preview-47053--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sairameshv sairameshv changed the title Place holder for a blog on Ensure secret pulled images feature Blog on "Ensure secret pulled images" feature Jul 12, 2024
@rashansmith
Copy link

Hello, I'm Rashan from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

gate

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@sairameshv sairameshv force-pushed the ensure-image-pull-blog branch from a3c4edf to 079672c Compare July 19, 2024 12:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
@sairameshv
Copy link
Member Author

Hello, I'm Rashan from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

Hey @rashansmith , Could you review the contents of this blog post and give some suggestions on it?

@sairameshv sairameshv marked this pull request as ready for review July 19, 2024 13:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@rashansmith
Copy link

Hello, I'm Rashan from the 1.31 Release comms team. I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024. Please let me know how we can help!

Hey @rashansmith , Could you review the contents of this blog post and give some suggestions on it?

will do!

@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

/hold

OK to unhold once Kubernetes v1.31 has been released.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a task rather than post-release publicity.

Have a look at some of the other blog articles that we've gone out; I think you'll see they tend to take a different angle.

You can also link to the documentation about KubeletEnsureSecretPulledImages.

@@ -0,0 +1,82 @@
---
layout: blog
title: "Kubernetes: 1.31 KubeletEnsureSecretPulledImages feature gate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Kubernetes: 1.31 KubeletEnsureSecretPulledImages feature gate"
title: "Kubernetes 1.31: Additional Security Measures For Container Image Pulls"

@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

BTW @rashansmith the blog reviewers would typically review, but it's great if you're willing to help line up a reviewer.

This is open source so you are of course welcome to do your own reviewing.

# Scenario: Enable KubeletEnsureSecretPulledImages FeatureGate

## Objective
Enable a new feature gate `KubeletEnsureSecretPulledImages` and create two pods that pull same image from a private registry (for ex: `quay.io`) with one pod configured with valid image pull credentials and another having invalid image pull credentials.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable a new feature gate `KubeletEnsureSecretPulledImages` and create two pods that pull same image from a private registry (for ex: `quay.io`) with one pod configured with valid image pull credentials and another having invalid image pull credentials.
Enable a new feature gate `KubeletEnsureSecretPulledImages` and create two pods that pull same
image from a private registry (for ex: `quay.io`) with one pod configured with valid image
pull credentials and another having invalid image pull credentials.

Modify the kubelet configuration by setting the `KubeletEnsureSecretPulledImages` feature gate to `false` and verify both the pods are `Running` successfully which is the default/current behavior.

### Conclusion
As of today, if a pod pulls an image from a private registry with valid credentials on to a node, the same can be leveraged by any another pod on the same node even without a valid image pull seceret/credentials.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As of today, if a pod pulls an image from a private registry with valid credentials on to a node, the same can be leveraged by any another pod on the same node even without a valid image pull seceret/credentials.
As of today, if a pod pulls an image from a private registry with valid credentials on to a node, the same can be
leveraged by any another pod on the same node even without a valid image pull seceret/credentials.


### Conclusion
As of today, if a pod pulls an image from a private registry with valid credentials on to a node, the same can be leveraged by any another pod on the same node even without a valid image pull seceret/credentials.
This newly introduced feature would help the cluster admin to have a better access control in terms of multi tenant scenarios by allowing the access of an image only incase of having a valid credentials even if the image is already present on the node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This newly introduced feature would help the cluster admin to have a better access control in terms of multi tenant scenarios by allowing the access of an image only incase of having a valid credentials even if the image is already present on the node.
This newly introduced feature would help the cluster admin to have a better access control
in terms of multi tenant scenarios by allowing the access of an image only incase of having
a valid credentials even if the image is already present on the node.

@T-Lakshmi
Copy link
Contributor

T-Lakshmi commented Jul 29, 2024

@sairameshv,

As @sftim mentioned, this content format is not looking like blog post publicity.
Suggesting you to have a look on existing blogs content and try if you can improve the content.
Thanks.

WDYT?

@T-Lakshmi
Copy link
Contributor

Preview page

@divya-mohan0209
Copy link
Contributor

@sairameshv / @sftim : Please may I know the status of this blogpost? Are we considering pushing it forward to a later date?

@sairameshv
Copy link
Member Author

Hey @divya-mohan0209 , There is a new PR for the KEP proposing changes to this feature and that may require a new PR based on the latest behavior.
Hence, Closing this PR in favor of the same.

/close

@k8s-ci-robot
Copy link
Contributor

@sairameshv: Closed this PR.

In response to this:

Hey @divya-mohan0209 , There is a new PR for the KEP proposing changes to this feature and that may require a new PR based on the latest behavior.
Hence, Closing this PR in favor of the same.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Requires update
Development

Successfully merging this pull request may close these issues.

6 participants