Update Quobyte StorageClass reference #27645

venkatsc · 2021-04-21T09:28:02Z

Quobyte no longer recommends usage of in-tree plugin, instead
uses CSI driver. The current StorageClass example is based
on the in-tree plugin and out-dated. This patch points to the
example StorageClass available at the Quobyte CSI repository.

In response to #27631 (comment), posting it on dev-1.22 branch

Quobyte no longer recommends usage of in-tree plugin, instead uses CSI driver. The current StorageClass example is based on the in-tree plugin and out-dated. This patch points to the example StorageClass available at the Quobyte CSI repository.

k8sio-netlify-preview-bot · 2021-04-21T09:28:06Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit d65735a

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/607ff0231ec6d00007d12320

k8s-ci-robot · 2021-04-21T09:28:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah after the PR has been reviewed.
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

venkatsc · 2021-04-21T09:29:03Z

/assign @sftim

kbhawkey · 2021-04-22T01:13:42Z

/cc @PI-Victor

sftim

this review repeats comments from #27631 (review)

/sig storage

Even [if / though] the quobyte provider is deprecated, we should still document it as it is one of the in-tree storage providers until it is removed.

It is OK to add a callout to explain there is a recommended alternative.

/hold

because we should not remove documentation for features that remain present.

fejta-bot · 2021-07-21T09:42:43Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

reylejano · 2021-07-22T17:42:08Z

/remove-lifecycle stale

reylejano · 2021-07-22T17:45:32Z

@kubernetes/sig-storage-pr-reviews , ptal at @sftim's comment:

Even [if / though] the quobyte provider is deprecated, we should still document it as it is one of the in-tree storage providers until it is removed.

It is OK to add a callout to explain there is a recommended alternative.
...
because we should not remove documentation for features that remain present.

jsafrane · 2021-07-23T10:18:18Z

I think @sftim's comment is accurate. We should document that in-tree Quobyte API still exists, mention it's deprecated and point users to CSI.

PI-Victor · 2021-07-26T18:44:30Z

@venkatsc can you please address the above comments?

sftim · 2021-07-26T22:11:43Z

If necessary, could someone from SIG Storage (or, at a pinch, SIG Docs) open a new equivalent PR that takes account of feedback so far?

xing-yang · 2021-07-28T14:43:50Z

If necessary, could someone from SIG Storage (or, at a pinch, SIG Docs) open a new equivalent PR that takes account of feedback so far?

@sftim Where should we document that in-tree Quobyte API still exists, mention it's deprecated and point users to CSI? Should that be part of this PR?

xing-yang · 2021-07-28T14:48:50Z

@venkatsc shouldn't this be removed? https://github.com/kubernetes/kubernetes/blob/v1.23.0-alpha.0/pkg/apis/core/types.go#L107
Are there any deprecation messages in the release notes before the in-tree plugin becomes unsupported?

sftim · 2021-07-28T14:54:48Z

If SIG Storage are planning to deprecate the in-tree Quobyte storage mechanism, then some PR for the v1.22 docs should update the documentation to say so. It can be this PR or a different PR. Also that will need a tech review from SIG Storage to confirm the deprecation.

(My opinion: if we don't document it as deprecated,we should defer the removal by an extra release for each release where we missed out documenting the deprecation)

sftim · 2021-07-28T14:57:04Z

content/en/docs/concepts/storage/storage-classes.md

@@ -548,52 +548,8 @@ parameters:

 ### Quobyte



If deprecating this, try:

Suggested change

{{< feature-state for_k8s_version="v1.22" state="deprecated" >}}

The Quobyte storage plugin is deprecated.

and then leave in the docs about how to use it, unless there's a strong reason to remove them early.

When we remove in-tree Quobyte support, we can delete this section entirely.

Sounds good.

xing-yang · 2021-07-28T17:31:07Z

Okay, I see that deprecation message is already added in this PR for v1.22:
kubernetes/kubernetes#101773

xing-yang · 2021-07-28T17:33:10Z

We also need to add a note for "quobyte" volume type under the following section that the in-tree driver is deprecated:
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes

xing-yang · 2021-07-28T17:35:46Z

content/en/docs/concepts/storage/storage-classes.md

-* `quobyteTenant`: use the specified tenant ID to create/delete the volume.
-  This Quobyte tenant has to be already present in Quobyte.
-  Default is "DEFAULT".
+An [example](https://github.com/quobyte/quobyte-csi/blob/master/example/StorageClass.yaml)


Keep the above in-tree example for now. Remove this section when the in-tree driver code is removed. We normally have to wait a year after it is deprecated before removing the code. You can add a link to the CSI driver repo.

PI-Victor · 2021-07-28T18:19:55Z

without any feedback whatsoever from the original PR owner, and due to the fact that this was opened back in April, i suggest we move this to a new PR. Anyone from sig-storage wanna tackle this or should i open one?

PI-Victor · 2021-07-28T19:13:52Z

/close
in favor of #29144

k8s-ci-robot · 2021-07-28T19:14:01Z

@PI-Victor: Closed this PR.

In response to this:

/close
in favor of #29144

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Update Quobyte StorageClass reference

d65735a

Quobyte no longer recommends usage of in-tree plugin, instead uses CSI driver. The current StorageClass example is based on the in-tree plugin and out-dated. This patch points to the example StorageClass available at the Quobyte CSI repository.

k8s-ci-robot added this to the 1.22 milestone Apr 21, 2021

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2021

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2021

k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 21, 2021

k8s-ci-robot requested review from msau42 and thockin April 21, 2021 09:28

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 21, 2021

k8s-ci-robot assigned sftim Apr 21, 2021

k8s-ci-robot requested a review from PI-Victor April 22, 2021 01:13

sftim reviewed Apr 22, 2021

View reviewed changes

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 22, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2021

sftim reviewed Jul 28, 2021

View reviewed changes

xing-yang reviewed Jul 28, 2021

View reviewed changes

k8s-ci-robot closed this Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Quobyte StorageClass reference #27645

Update Quobyte StorageClass reference #27645

venkatsc commented Apr 21, 2021

k8sio-netlify-preview-bot commented Apr 21, 2021

k8s-ci-robot commented Apr 21, 2021

venkatsc commented Apr 21, 2021

kbhawkey commented Apr 22, 2021

sftim left a comment

fejta-bot commented Jul 21, 2021

reylejano commented Jul 22, 2021

reylejano commented Jul 22, 2021

jsafrane commented Jul 23, 2021

PI-Victor commented Jul 26, 2021

sftim commented Jul 26, 2021

xing-yang commented Jul 28, 2021

xing-yang commented Jul 28, 2021 •

edited

Loading

sftim commented Jul 28, 2021

sftim Jul 28, 2021

xing-yang Jul 28, 2021

xing-yang commented Jul 28, 2021

xing-yang commented Jul 28, 2021

xing-yang Jul 28, 2021

PI-Victor commented Jul 28, 2021

PI-Victor commented Jul 28, 2021

k8s-ci-robot commented Jul 28, 2021



	{{< feature-state for_k8s_version="v1.22" state="deprecated" >}}

	The Quobyte storage plugin is deprecated.

Update Quobyte StorageClass reference #27645

Update Quobyte StorageClass reference #27645

Conversation

venkatsc commented Apr 21, 2021

k8sio-netlify-preview-bot commented Apr 21, 2021

k8s-ci-robot commented Apr 21, 2021

venkatsc commented Apr 21, 2021

kbhawkey commented Apr 22, 2021

sftim left a comment

Choose a reason for hiding this comment

fejta-bot commented Jul 21, 2021

reylejano commented Jul 22, 2021

reylejano commented Jul 22, 2021

jsafrane commented Jul 23, 2021

PI-Victor commented Jul 26, 2021

sftim commented Jul 26, 2021

xing-yang commented Jul 28, 2021

xing-yang commented Jul 28, 2021 • edited Loading

sftim commented Jul 28, 2021

sftim Jul 28, 2021

Choose a reason for hiding this comment

xing-yang Jul 28, 2021

Choose a reason for hiding this comment

xing-yang commented Jul 28, 2021

xing-yang commented Jul 28, 2021

xing-yang Jul 28, 2021

Choose a reason for hiding this comment

PI-Victor commented Jul 28, 2021

PI-Victor commented Jul 28, 2021

k8s-ci-robot commented Jul 28, 2021

xing-yang commented Jul 28, 2021 •

edited

Loading