Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in concepts section #22557

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Fix links in concepts section #22557

merged 1 commit into from
Aug 1, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 17, 2020

We are still referencing the redirect entries in the docs, at many places.
These references should be updated to the correct content page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 17, 2020
@netlify
Copy link

netlify bot commented Jul 17, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0bdcd44

https://deploy-preview-22557--kubernetes-io-master-staging.netlify.app

sftim
sftim reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough work
/lgtm

content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md



Familiarity with [Pods](/docs/concepts/workloads/pods/pod/) is suggested.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a glossary tooltip here; however, this is fine.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2020
@sftim
Copy link
Contributor

sftim commented Jul 19, 2020

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 19, 2020
@jimangel
Copy link
Member

Thanks @tengqm! Please rebase when time permits!

@tengqm
Replace reference to redirect entries (1)
0bdcd44 
We are referencing the redirect entries in the docs, at many places.
These references should be updated to the correct content page.
@tengqm tengqm force-pushed the fix-links-concepts branch from d00e475 to 0bdcd44 Compare July 27, 2020 05:37
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020
@jimangel
Copy link
Member

jimangel commented Aug 1, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit e4f6797 into kubernetes:master Aug 1, 2020
@tengqm tengqm deleted the fix-links-concepts branch August 2, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bprashanth bprashanth Awaiting requested review from bprashanth

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@jimangel jimangel

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tengqm @sftim @jimangel @k8s-ci-robot