-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set "host is down" as corrupted mount #203
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Another PR in k/k that could finally solves the SMB server down issue when terminating pods:
|
We moved the mount library back into kubernetes/staging. This repo is no longer being used for mount utils. |
thanks, this PR would fix the issue: kubernetes/kubernetes#101305 |
@msau42 I found this repo is still used by SMB CSI driver: https://github.com/kubernetes-csi/csi-driver-smb/blob/2fd1672aa1c57f6a1243cba89ae6c4187b425135/go.mod#L28, shall we merge this PR? |
I think it's better if smb driver switches to the new repo: https://github.com/kubernetes/mount-utils There's already a few PR differences between these two repos. |
@msau42 so this repo is deprecated? I am quite confused about these two repos |
Yes this repo is deprecated. @brahmaroutu can you send a PR to deprecate/remove this? |
close this PR, opened another PR: kubernetes/mount-utils#3 |
maybe we could merge this PR this time since some CSI drivers still depend on this? |
i think most driver still uses kubernetes/mount-utils, worth to discuss how to migrate all of them? |
The interfaces should be mostly the same. It should just be changing the package name. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: set "host is down" as corrupted mount
When SMB server is down, there is no way to terminate pod which is using SMB mount, would get following error. This PR regard
host is down
as corrupted mount dir, and then I would work out another PR in k8s to skipUnmountVolume.TearDown
process ifhost is down
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: