Fix KeyError for 3-part versions. #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
enisoc
force-pushed
the
three-part-version
branch
from
0a06971 to
a8a7374
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I tested the regexes manually, merging now. |
|
@rmmh Thanks! How do changes to these files take effect? It seems like the two PRs above still fail with the same error. |
|
Oh actually they are passing. I must have been looking at the wrong gubernator links. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2778.
cc @fejta @david-mcmahon
This is blocking kubernetes/kubernetes#46046 and kubernetes/kubernetes#46049, which are needed for the emergency v1.6.4 release.
What is needed to push changes in these files to Jenkins?