Test build for testing new release infra push-ci-build.sh #279
Conversation
|
You'll need to make a PR to put the |
| # limitations under the License. | ||
|
|
||
| ### | ||
| ### NOTE: Replacement for hack/jenkins/build.sh ??? |
There was a problem hiding this comment.
Looking at build.sh, it sure looks like a candidate to move into test-infra anyway, no?
It's very jenkins specific and very test-infra specific and no doubt only lives in kubernetes proper for historical reasons. Adding this modified new version here in the hopes I can help make this the first of many scripts moved out of hack/jenkins over to test-infra?
There was a problem hiding this comment.
I agree, but we are holding off on bringing code from hack/jenkins to this repository until we have CI set up for them. Currently, hack/jenkins/build.sh gets hit by PR Jenkins so at least we have a little bit of signal that it works.
david-mcmahon
force-pushed
the
test-build
branch
from
c40bc87 to
e0964af
Compare
|
PTAL |
| export KUBE_GCS_RELEASE_BUCKET=kubernetes-federation-release | ||
| export KUBE_GCS_RELEASE_BUCKET_MIRROR=kubernetes-federation-release | ||
| jobs: | ||
| - 'kubernetes-{djmm}' |
There was a problem hiding this comment.
It's confusing, but {djmm} is a variable that expands to the job name. You never define the djmm variable so it's invalid. What do you want to name your Jenkins jobs?
There was a problem hiding this comment.
I knew that one was wrong. I just didn't know what it should be. :) I mean, I just want jobs called kubernetes-djmm for now. That seems reasonable, right? But how do I do that? Or is there a better naming convention? Can I leave that up to you? I don't care. I just want my own namespace, however that looks best in a jenkins context.
There was a problem hiding this comment.
ping. I need your guidance here.
There was a problem hiding this comment.
Oh, right, sorry.
The template will expand any values of djmm into the name of the job. Here you don't define that anywhere, so it doesn't work. Do you want to make two jobs or just one?
There was a problem hiding this comment.
Oh I see. we'll keep {build} then and change kubernetes to djmm. The job name will appear as djmm-build on kubekins.dls.corp.google.com, yes?
There was a problem hiding this comment.
Yep. You'll also need to change the last line to 'djmm-{build}.
There was a problem hiding this comment.
Oh yes, thanks. done.
david-mcmahon
force-pushed
the
test-build
branch
2 times, most recently
from
0331b07 to
53d7305
Compare
| - shell: 'JENKINS_BUILD_STARTED=true bash <(curl -fsS --retry 3 "https://raw.githubusercontent.com/kubernetes/kubernetes/master/hack/jenkins/upload-to-gcs.sh")' | ||
| - shell: | | ||
| {job-env} | ||
| TODO: How do I call the new build.sh from test-infra here? |
There was a problem hiding this comment.
Good catch. Thanks. Done.
david-mcmahon
force-pushed
the
test-build
branch
from
53d7305 to
91fc9df
Compare
| external-deletion-command: 'sudo rm -rf %s' | ||
|
|
||
| - project: | ||
| name: kubernetes-builds |
There was a problem hiding this comment.
I think this needs to be unique between all jobs.
There was a problem hiding this comment.
Hopefully that does it?
david-mcmahon
force-pushed
the
test-build
branch
from
91fc9df to
cfb3f5c
Compare
|
Looks fine. Merge whenever it's time, and keep an eye on Jenkins. |
spxtr
added
the
lgtm
|
The job has been failing since the first run and has been sending out warning emails to many people. Is it possible stop the emails until the build is stable? Thanks. |
|
@caesarxuchao Thanks for telling me. I had no idea. @ixdy @spxtr How do I disable email notifications for this test job? |
| publishers: | ||
| - claim-build | ||
| - log-parser | ||
| - email-ext: |
There was a problem hiding this comment.
Delete this publisher to make it stop sending emails.
Part of knative/serving#2555. Bonus: block running E2E tests using knative-nightly GCR as well.
* refactor: rename apps to cmd and add go.mod * Structure Makefile and go.mod files for multimodule builds+testing. Co-authored-by: Tim Burks <timburks@google.com>
I'm sure this is completely wrong, but just moving the conversation to a PR. Please advise.
ref kubernetes/kubernetes#28922
ref kubernetes/kubernetes#16529