Pull kubectl-skew tests out from other upgrade tests, since it's a different matrix #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also removes the usage of |
|
cc @maisem |
ikehz
force-pushed
the
separate-client-matrix
branch
from
01551b1 to
05609aa
Compare
| provider: 'gke' | ||
| provider-env: '{gke-provider-env}' | ||
| jobs: | ||
| - 'kubernetes-e2e-{provider}-{version-cluster}-{version-client}-kubctl-skew': |
ikehz
force-pushed
the
separate-client-matrix
branch
from
05609aa to
b9d4902
Compare
|
@spxtr PTAL. |
|
Looks fine to me. cc @fejta who is looking into cleaning up this file. I think the plan is to move the upgrade jobs into their own file. We'll have to duplicate the job template stuff, but I think that's fine. |
|
I'll happily make sure to merge your changes |
spxtr
added
the
lgtm
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jun 7, 2016
Automatic merge from submit-queue Always skew the client when running version-skew tests As mentioned in the comments: - for upgrade jobs, we want kubectl to be at the same version as master. - for client skew tests, we want to use the skewed kubectl (that's what we're testing). So, remove gate on `JENKINS_USE_SKEW_KUBECTL`, and always use the skewed `kubectl`. This should go in before kubernetes/test-infra#109.
|
kubernetes/kubernetes#26789 is in; merging this. |
simonswine
pushed a commit
to simonswine/test-infra
that referenced
this pull request
Jan 16, 2018
Rollback minikube to 0.23.0
mborsz
pushed a commit
to mborsz/test-infra
that referenced
this pull request
Dec 14, 2018
Updating go version.
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of kubernetes/kubernetes#25087; the matrix that we care about is different for node-master and client-master skews.