Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mungegithub] Bot mis-labels PRs when Github fails #1637

Closed
foxish opened this issue Jan 21, 2017 · 2 comments
Closed

[mungegithub] Bot mis-labels PRs when Github fails #1637

foxish opened this issue Jan 21, 2017 · 2 comments

Comments

@foxish
Copy link
Contributor

foxish commented Jan 21, 2017

From @apelisse on July 28, 2016 16:9

Looks like Github had a hiccup yesterday. We should deal with that properly.

Trying to find the full list of where it happened:
kubernetes/kubernetes#29618
kubernetes/kubernetes#29619
kubernetes/kubernetes#29622
kubernetes/kubernetes#29623
kubernetes/kubernetes#29631
kubernetes/kubernetes#29632
kubernetes/kubernetes#29634
kubernetes/kubernetes#29639
kubernetes/kubernetes#29648
kubernetes/kubernetes#29649
kubernetes/kubernetes#29650
kubernetes/kubernetes#29652
kubernetes/kubernetes#29653
kubernetes/kubernetes#29655
kubernetes/kubernetes#29658
kubernetes/kubernetes#29663

I'll go through the code and see if we have proper error handling.

Impacted mungers:
mungers/cherrypick-label-unapproved.go
mungers/docs-no-retest.go

Copied from original issue: kubernetes-retired/contrib#1445
@foxish
Copy link
Contributor Author

foxish commented Jan 21, 2017

From @apelisse on July 30, 2016 3:25

kubernetes-retired/contrib#1446 tentatively fixes that.
It's being blocked because a big refactoring would be better, but I'm not sure if we shouldn't fix the issue before the problem happens again.

@foxish
Copy link
Contributor Author

foxish commented Jan 21, 2017

From @apelisse on August 20, 2016 19:6

Recovery script and log:

// Munge is the workhorse the will actually make updates to the PR
func (s *RemoveStupidDoNotMerge) Munge(obj *github.MungeObject) {
    if !obj.IsPR() {
        return
    }

    if !obj.HasLabel("do-not-merge") {
        return
    }

    events, err := obj.GetEvents()
    if err != nil {
        glog.Error("Failed to get events: ", err)
        return
    }
    events = event.FindEvent(events, event.And([]event.Matcher{
        event.Actor("k8s-merge-robot"),
        event.AddLabel("do-not-merge"),
        event.CreatedAfter(time.Date(2016, 7, 27, 0, 0, 0, 0, time.UTC)),
        event.CreatedBefore(time.Date(2016, 7, 28, 0, 0, 0, 0, time.UTC)),
    }))
    if len(events) == 0 {
        return
    }

    obj.RemoveLabel("do-not-merge")
}

// Output:
// I0811 16:54:13.287798   74431 github.go:739] Removing label "do-not-merge" to PR 16062
// I0811 16:54:14.358574   74431 github.go:739] Removing label "do-not-merge" to PR 16933
// I0811 16:54:16.252257   74431 github.go:739] Removing label "do-not-merge" to PR 18016
// I0811 16:54:17.221218   74431 github.go:739] Removing label "do-not-merge" to PR 19108
// I0811 16:54:18.233749   74431 github.go:739] Removing label "do-not-merge" to PR 20043
// I0811 16:54:19.306516   74431 github.go:739] Removing label "do-not-merge" to PR 20113
// I0811 16:54:19.771450   74431 github.go:739] Removing label "do-not-merge" to PR 20321
// I0811 16:54:20.751868   74431 github.go:739] Removing label "do-not-merge" to PR 21137
// I0811 16:54:21.235525   74431 github.go:739] Removing label "do-not-merge" to PR 21228
// I0811 16:54:22.963487   74431 github.go:739] Removing label "do-not-merge" to PR 22216
// I0811 16:54:23.943521   74431 github.go:739] Removing label "do-not-merge" to PR 22831
// I0811 16:54:25.244293   74431 github.go:739] Removing label "do-not-merge" to PR 23811
// I0811 16:54:26.369562   74431 github.go:739] Removing label "do-not-merge" to PR 24042
// I0811 16:54:27.348080   74431 github.go:739] Removing label "do-not-merge" to PR 24456
// I0811 16:54:28.087229   74431 github.go:739] Removing label "do-not-merge" to PR 24962
// I0811 16:54:28.690544   74431 github.go:739] Removing label "do-not-merge" to PR 24977
// I0811 16:54:29.165752   74431 github.go:739] Removing label "do-not-merge" to PR 24980
// I0811 16:54:29.397118   74431 github.go:739] Removing label "do-not-merge" to PR 25026
// I0811 16:54:29.661045   74431 github.go:739] Removing label "do-not-merge" to PR 25107
// I0811 16:54:30.090204   74431 github.go:739] Removing label "do-not-merge" to PR 25302
// I0811 16:54:30.345570   74431 github.go:739] Removing label "do-not-merge" to PR 25329
// I0811 16:54:31.486053   74431 github.go:739] Removing label "do-not-merge" to PR 25532
// I0811 16:54:31.930360   74431 github.go:739] Removing label "do-not-merge" to PR 25546
// I0811 16:54:32.281494   74431 github.go:739] Removing label "do-not-merge" to PR 25680
// I0811 16:54:33.166428   74431 github.go:739] Removing label "do-not-merge" to PR 25810
// I0811 16:54:33.407096   74431 github.go:739] Removing label "do-not-merge" to PR 25821
// I0811 16:54:33.820804   74431 github.go:739] Removing label "do-not-merge" to PR 25859
// I0811 16:54:34.026512   74431 github.go:739] Removing label "do-not-merge" to PR 25906
// I0811 16:54:34.234018   74431 github.go:739] Removing label "do-not-merge" to PR 25941
// I0811 16:54:34.454176   74431 github.go:739] Removing label "do-not-merge" to PR 26037
// I0811 16:54:34.666152   74431 github.go:739] Removing label "do-not-merge" to PR 26244
// I0811 16:54:35.496496   74431 github.go:739] Removing label "do-not-merge" to PR 26501
// I0811 16:54:35.936017   74431 github.go:739] Removing label "do-not-merge" to PR 26510
// I0811 16:54:36.172705   74431 github.go:739] Removing label "do-not-merge" to PR 26520
// I0811 16:54:36.450403   74431 github.go:739] Removing label "do-not-merge" to PR 26538
// I0811 16:54:36.665004   74431 github.go:739] Removing label "do-not-merge" to PR 26720
// I0811 16:54:37.084536   74431 github.go:739] Removing label "do-not-merge" to PR 26765
// I0811 16:54:37.285529   74431 github.go:739] Removing label "do-not-merge" to PR 26786
// I0811 16:54:37.732739   74431 github.go:739] Removing label "do-not-merge" to PR 26788
// I0811 16:54:38.170201   74431 github.go:739] Removing label "do-not-merge" to PR 26858
// I0811 16:54:39.470641   74431 github.go:739] Removing label "do-not-merge" to PR 26875
// I0811 16:54:39.861294   74431 github.go:739] Removing label "do-not-merge" to PR 26926
// I0811 16:54:40.206044   74431 github.go:739] Removing label "do-not-merge" to PR 27061
// I0811 16:54:40.421361   74431 github.go:739] Removing label "do-not-merge" to PR 27066
// I0811 16:54:40.633852   74431 github.go:739] Removing label "do-not-merge" to PR 27080
// I0811 16:54:41.102274   74431 github.go:739] Removing label "do-not-merge" to PR 27193
// I0811 16:54:41.540845   74431 github.go:739] Removing label "do-not-merge" to PR 27203
// I0811 16:54:41.791465   74431 github.go:739] Removing label "do-not-merge" to PR 27275
// I0811 16:54:42.995317   74431 github.go:739] Removing label "do-not-merge" to PR 27336
// I0811 16:54:43.196792   74431 github.go:739] Removing label "do-not-merge" to PR 27386
// I0811 16:54:43.394908   74431 github.go:739] Removing label "do-not-merge" to PR 27459
// I0811 16:54:43.651285   74431 github.go:739] Removing label "do-not-merge" to PR 27510
// I0811 16:54:43.853853   74431 github.go:739] Removing label "do-not-merge" to PR 27555
// I0811 16:54:44.291317   74431 github.go:739] Removing label "do-not-merge" to PR 27640
// I0811 16:54:44.541140   74431 github.go:739] Removing label "do-not-merge" to PR 27711
// I0811 16:54:45.602635   74431 github.go:739] Removing label "do-not-merge" to PR 27778
// I0811 16:54:45.831883   74431 github.go:739] Removing label "do-not-merge" to PR 27783
// I0811 16:54:46.066341   74431 github.go:739] Removing label "do-not-merge" to PR 27860
// I0811 16:54:46.319579   74431 github.go:739] Removing label "do-not-merge" to PR 27880
// I0811 16:54:46.792517   74431 github.go:739] Removing label "do-not-merge" to PR 27956
// I0811 16:54:46.993428   74431 github.go:739] Removing label "do-not-merge" to PR 28085
// I0811 16:54:47.209619   74431 github.go:739] Removing label "do-not-merge" to PR 28120
// I0811 16:54:47.420418   74431 github.go:739] Removing label "do-not-merge" to PR 28136
// I0811 16:54:48.480554   74431 github.go:739] Removing label "do-not-merge" to PR 28209
// I0811 16:54:48.975720   74431 github.go:739] Removing label "do-not-merge" to PR 28216
// I0811 16:54:49.186256   74431 github.go:739] Removing label "do-not-merge" to PR 28270
// I0811 16:54:49.400311   74431 github.go:739] Removing label "do-not-merge" to PR 28279
// I0811 16:54:49.812991   74431 github.go:739] Removing label "do-not-merge" to PR 28284
// I0811 16:54:50.088623   74431 github.go:739] Removing label "do-not-merge" to PR 28300
// I0811 16:54:50.493715   74431 github.go:739] Removing label "do-not-merge" to PR 28412
// I0811 16:54:50.722587   74431 github.go:739] Removing label "do-not-merge" to PR 28422
// I0811 16:54:51.261133   74431 github.go:739] Removing label "do-not-merge" to PR 28432
// I0811 16:54:52.114629   74431 github.go:739] Removing label "do-not-merge" to PR 28469
// I0811 16:54:52.346289   74431 github.go:739] Removing label "do-not-merge" to PR 28499
// I0811 16:54:52.588174   74431 github.go:739] Removing label "do-not-merge" to PR 28508
// I0811 16:54:53.044091   74431 github.go:739] Removing label "do-not-merge" to PR 28568
// I0811 16:54:53.467868   74431 github.go:739] Removing label "do-not-merge" to PR 28621
// I0811 16:54:53.687552   74431 github.go:739] Removing label "do-not-merge" to PR 28628
// I0811 16:54:54.099502   74431 github.go:739] Removing label "do-not-merge" to PR 28637
// I0811 16:54:54.528724   74431 github.go:739] Removing label "do-not-merge" to PR 28696
// I0811 16:54:54.933287   74431 github.go:739] Removing label "do-not-merge" to PR 28717
// I0811 16:54:55.799789   74431 github.go:739] Removing label "do-not-merge" to PR 28742
// I0811 16:54:56.019519   74431 github.go:739] Removing label "do-not-merge" to PR 28759
// I0811 16:54:56.284975   74431 github.go:739] Removing label "do-not-merge" to PR 28816
// I0811 16:54:56.486872   74431 github.go:739] Removing label "do-not-merge" to PR 28837
// I0811 16:54:56.700751   74431 github.go:739] Removing label "do-not-merge" to PR 28856
// I0811 16:54:56.940670   74431 github.go:739] Removing label "do-not-merge" to PR 28860
// I0811 16:54:57.163781   74431 github.go:739] Removing label "do-not-merge" to PR 28913
// I0811 16:54:57.416331   74431 github.go:739] Removing label "do-not-merge" to PR 28921
// I0811 16:54:57.657155   74431 github.go:739] Removing label "do-not-merge" to PR 28949
// I0811 16:54:57.857988   74431 github.go:739] Removing label "do-not-merge" to PR 28954
// I0811 16:54:58.077129   74431 github.go:739] Removing label "do-not-merge" to PR 28995
// I0811 16:54:59.308147   74431 github.go:739] Removing label "do-not-merge" to PR 29037
// I0811 16:54:59.520718   74431 github.go:739] Removing label "do-not-merge" to PR 29104
// I0811 16:54:59.722013   74431 github.go:739] Removing label "do-not-merge" to PR 29116
// I0811 16:54:59.921256   74431 github.go:739] Removing label "do-not-merge" to PR 29150
// I0811 16:55:00.159857   74431 github.go:739] Removing label "do-not-merge" to PR 29180
// I0811 16:55:00.379691   74431 github.go:739] Removing label "do-not-merge" to PR 29183
// I0811 16:55:00.747045   74431 github.go:739] Removing label "do-not-merge" to PR 29195
// I0811 16:55:01.652576   74431 github.go:739] Removing label "do-not-merge" to PR 29236
// I0811 16:55:01.913431   74431 github.go:739] Removing label "do-not-merge" to PR 29281
// I0811 16:55:02.135787   74431 github.go:739] Removing label "do-not-merge" to PR 29282
// I0811 16:55:02.382198   74431 github.go:739] Removing label "do-not-merge" to PR 29293
// I0811 16:55:03.399536   74431 github.go:739] Removing label "do-not-merge" to PR 29378
// I0811 16:55:03.631206   74431 github.go:739] Removing label "do-not-merge" to PR 29409
// I0811 16:55:04.065013   74431 github.go:739] Removing label "do-not-merge" to PR 29437
// I0811 16:55:04.298101   74431 github.go:739] Removing label "do-not-merge" to PR 29443
// I0811 16:55:04.850969   74431 github.go:739] Removing label "do-not-merge" to PR 29459
// I0811 16:55:05.315733   74431 github.go:739] Removing label "do-not-merge" to PR 29460
// I0811 16:55:05.730947   74431 github.go:739] Removing label "do-not-merge" to PR 29464
// I0811 16:55:06.004354   74431 github.go:739] Removing label "do-not-merge" to PR 29465
// I0811 16:55:06.378110   74431 github.go:739] Removing label "do-not-merge" to PR 29466
// I0811 16:55:06.671863   74431 github.go:739] Removing label "do-not-merge" to PR 29479
// I0811 16:55:07.115729   74431 github.go:739] Removing label "do-not-merge" to PR 29481
// I0811 16:55:07.544867   74431 github.go:739] Removing label "do-not-merge" to PR 29489
// I0811 16:55:07.752369   74431 github.go:739] Removing label "do-not-merge" to PR 29491
// I0811 16:55:07.983847   74431 github.go:739] Removing label "do-not-merge" to PR 29636
// I0811 16:55:08.229308   74431 github.go:739] Removing label "do-not-merge" to PR 29637
// I0811 16:55:09.056576   74431 github.go:739] Removing label "do-not-merge" to PR 29664
// I0811 16:55:09.279212   74431 github.go:739] Removing label "do-not-merge" to PR 29666
// I0811 16:55:09.493001   74431 github.go:739] Removing label "do-not-merge" to PR 29680
// I0811 16:55:09.735999   74431 github.go:739] Removing label "do-not-merge" to PR 29683
// I0811 16:55:09.942645   74431 github.go:739] Removing label "do-not-merge" to PR 29684
// I0811 16:55:10.153439   74431 github.go:739] Removing label "do-not-merge" to PR 29689
// I0811 16:55:10.362665   74431 github.go:739] Removing label "do-not-merge" to PR 29702
// I0811 16:55:10.577237   74431 github.go:739] Removing label "do-not-merge" to PR 29714
// I0811 16:55:11.041574   74431 github.go:739] Removing label "do-not-merge" to PR 29719

@foxish foxish mentioned this issue Jan 21, 2017
Closed
@fejta fejta closed this as completed May 17, 2017
grantr pushed a commit to grantr/test-infra that referenced this issue Feb 21, 2020
@knative-prow-updater-robot @knative-prow-robot
Update prow from v20200117-c08038c1c to v20200122-3d81e0e59, and othe…
7d91ab7 
…r images as necessary. (kubernetes#1637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foxish @fejta