Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned release notes final draft #2689

Closed
wants to merge 24 commits into from
Closed

cleaned release notes final draft #2689

wants to merge 24 commits into from

Conversation

satyampsoni
Copy link
Member

What type of PR is this:

/kind cleanup
/kind documentation

What this PR does / why we need it:

This PR refactors and fine-tunes all the release-notes for v1.31.0, and does the following:

  • Cleanups up md file
  • Cleans up the json files to make sure the website has the revised release notes

The major themes link to the upcoming release article will not be included as we are moving away from having major themes being a thing in future releases.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2024
@marosset
Copy link
Contributor

Can we get the release notes for kubernetes/kubernetes#128560 added after

sig-release/releases/release-1.32/release-notes/release-notes-draft.md

Line 152 in a9a90be

- Windows: Support CPU and Topology manager on Windows ([#125296](https://github.com/kubernetes/kubernetes/pull/125296), [@jsturtevant](https://github.com/jsturtevant)) [SIG Node and Windows]
?

Thanks!
cc @jsturtevant

@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2024
dom4ha
dom4ha reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@dom4ha dom4ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for scheduler
/cc @macsko @sanposhiho to look as well

releases/release-1.32/release-notes/release-notes-draft.md Show resolved Hide resolved
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

@sftim I've resolved all suggestions that I edited directly in both the JSON and MD (I copied the suggestion text instead of committing them to make it easier). Please take a look tough.

@sftim
Copy link
Contributor

sftim commented Dec 11, 2024

No objection to shipping what we have now.

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

Thank you @sftim , I think we only have one pending one which is about the clarity of the message.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, satyampsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 11, 2024
@fsmunoz fsmunoz mentioned this pull request Dec 11, 2024
Merged
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 11, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@npolshakova
Copy link
Contributor

Changes moved over to #2691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom4ha dom4ha dom4ha left review comments

@macsko macsko macsko left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@chengjoey chengjoey chengjoey left review comments

@sftim sftim sftim left review comments

@npolshakova npolshakova npolshakova left review comments

@aojea aojea aojea left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@fsmunoz fsmunoz fsmunoz approved these changes

@chanieljdan chanieljdan Awaiting requested review from chanieljdan

@drewhagen drewhagen Awaiting requested review from drewhagen

Assignees

@fsmunoz fsmunoz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.