Move push-ci-build.sh functionality to release repo. #29
Conversation
david-mcmahon
force-pushed
the
ci-api
branch
2 times, most recently
from
e479db2 to
0e5d6ff
Compare
david-mcmahon
changed the title
david-mcmahon
changed the title
david-mcmahon
force-pushed
the
ci-api
branch
3 times, most recently
from
7111d82 to
e476cae
Compare
david-mcmahon
changed the title
david-mcmahon
force-pushed
the
ci-api
branch
7 times, most recently
from
3430c8a to
ed07a89
Compare
|
Is this ready for review? |
david-mcmahon
force-pushed
the
ci-api
branch
3 times, most recently
from
ad35991 to
b717284
Compare
|
Yes, I'd like to push this soon to test out the new release-based push mechanism. |
|
@ixdy @spxtr Yes, if you could review this now. Please focus on what might be missing when run from within a Jenkins context. ref kubernetes/test-infra#279 |
|
ping. If you can just give this a quick check, that should be fine. I expect to iterate on this, but I need to get something in to feed initial jenkins job. |
| @@ -0,0 +1,3 @@ | |||
| # Continuous Integration How-to | |||
|
|
|||
| Called from hack/jenkins/build.sh | |||
There was a problem hiding this comment.
I assume another PR is going to do that?
There was a problem hiding this comment.
|
cc @zmerlynn too |
| elif [[ -z "$version_prerelease" && -n "$gcs_version_prerelease" ]]; then | ||
| : # fall out | ||
| elif [[ "$version_prerelease" < "$gcs_version_prerelease" ]]; then | ||
| greater=false | ||
| greater=0 | ||
| elif [[ "$version_prerelease" > "$gcs_version_prerelease" ]]; then | ||
| : # fall out | ||
| # Finally resort to -le here, since we want strictly-greater-than. |
| @@ -584,16 +605,16 @@ release::gcs::publish_official () { | |||
| # @param version - release version | |||
| # @return 1 if new version is not greater than the GCS version | |||
| # | |||
| release::gcs::verify_release_gt() { | |||
| release::gcs::verify_latest_update () { | |||
There was a problem hiding this comment.
tangential note: this method really wants unit tests.
|
Thanks for the comments. All addressed in some form. Agree on the unit test for release::gcs::verify_latest_update(). TODO for the moment. Plan to get some in shortly. |
david-mcmahon
force-pushed
the
ci-api
branch
2 times, most recently
from
9d63d18 to
8009c0d
Compare
|
@ixdy PTAL. Unit test added for release::gcs::verify_latest_update(). |
Add unit test for release::gcs::verify_latest_update().
|
If this is otherwise fine and good enough for testing the test yaml I'm going to merge this sometime this week. |
|
LGTM |
* Fix docker builds This updates to a recent stable container for building snaps via docker. Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com> * Include file in container, link magic db Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
cc @ixdy @spxtr
ref kubernetes/kubernetes#24629
ref kubernetes/kubernetes#16529